813982 - [Calendar][TR 11-15-12] Account configuration - Changing address and password to an already configured account is not working

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested with unagi with:

gaia 620399e
gecko 85d0121

STR:
1-Open calendar app
2-Go to accounts menu
3-Go to calendar settings
4-Select an already configured account
5-Change address and password to a new valid ones

Expected result --> New account should be configured
Actual result --> You get a message saying: No connection. Check your Wifi and try again.

Comment 1

[Jason Smith [:jsmith]]

Confirmed. That's umm...odd?

Comment 2

[James Lal [:lightsofapollo]]

Les, can you take this one? If you don't want it feel free to send it back my way.

Comment 3

[Les Orchard [:lorchard]]

Sure, I'll take a shot at stumbling through this one

Comment 4

[Les Orchard [:lorchard]]

Trying to narrow this down with gaia master - seems like the key to reproduce is:

Change the username, after which the CalDAV URL in the 3rd field doesn't update. Then, I get a "Server error. Check your login and try again." I don't see "No connection," so maybe the error message was updated? 

I presume this is the response to a 404 in the CalDAV URL

Comment 5

[James Lal [:lightsofapollo]]

I think that is a general 500 error (anything not ~200, 404, 0)

Comment 6

[James Lal [:lightsofapollo]]

I believe we do a request to get the home of the calendar user (in the worker) its possible this always fails when we already have it? Maybe comment out that part and see if it works. The rest looks sane to me upon my quick inspection of the code path.

Comment 8

[James Lal [:lightsofapollo]]

Tip (in case you did not know about it already) you can add logging here to see the raw output https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/ext/caldav.js#L2102.

Something like console.log(this._serialized()) will output the value we send as well.
I am fairly certain we sending the wrong kind of request to the caldav entrypoint.

Comment 9

[James Lal [:lightsofapollo]]

This seems to be google specific to me but this could also be an issue with other servers. The simple fix is to save the original url the user gives us as "entrypointUri" that we use for re-authenticating users. When making the calendar home request we then always pass user input or entrypointUri.

Comment 10

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6790

Pointer to Github pull-request

Comment 11

[James Lal [:lightsofapollo]]

Comment on attachment 687937 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6790

This requires a db update to fix. For most users using a preset (Google, Yahoo, Zimbra) you won't notice a thing. 

If your using a custom caldav account though you will need to delete and add your account again (if editing credentials does not work). If they don't need to edit the credentials this has no impact on those users.

Comment 12

[sarsenyev]

Reviewed and verified on "Unagi" device
Build ID:20130102070202