Closed Bug 814006 Opened 12 years ago Closed 12 years ago

Mozpool request id field should be BIGINT

Categories

(Testing Graveyard :: Mozpool, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhopkins, Unassigned)

Details

I noticed the Mozpool request id field is type INTEGER.

Since we're going to handle tons of requests over the lifetime of this system, I think we should change the data type of that field to BIGINT to avoid an overflow in the future.
Ran into a slight problem, in that sqlite has issues with bigint as a primary key (or at least as autoincrement). Got errors about having to specify the request id when adding to the table. Fixed by leaving the model as is but changing the schema to bigint. Dustin assures me that the fact that it's specified as Integer in the model won't affect anything; sqlalchemy won't enforce size limits.

Code has been pushed; just need to update the prod db.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.