Closed Bug 814061 Opened 10 years ago Closed 10 years ago

BaselineCompiler: Fix x64 test failures

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: evilpie, Unassigned)

References

Details

Attachments

(1 file)

No description provided.
Attached patch v1Splinter Review
JIT test failures left over are.

    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/arguments/args-mochi.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/argumentsOptimize-2.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/testSetElem-Indexed.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/recompile/bug671943-2.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/recompile/memory-01.js

The first two are also failing on x86. The third one is recent. The fourth one depends on an gc(); call.
Attachment #684075 - Flags: review?(kvijayan)
Comment on attachment 684075 [details] [diff] [review]
v1

Review of attachment 684075 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #684075 - Flags: review?(kvijayan) → review+
Can this be closed or turned into a meta?
I'm thinking we can keep this open for fixing ongoing test failures that show up on x64 as development proceeds.
All green now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.