If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

BaselineCompiler: Fix x64 test failures

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evilpie, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
Created attachment 684075 [details] [diff] [review]
v1

JIT test failures left over are.

    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/arguments/args-mochi.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/argumentsOptimize-2.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/testSetElem-Indexed.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/recompile/bug671943-2.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/recompile/memory-01.js

The first two are also failing on x86. The third one is recent. The fourth one depends on an gc(); call.
(Reporter)

Updated

5 years ago
Attachment #684075 - Flags: review?(kvijayan)
Comment on attachment 684075 [details] [diff] [review]
v1

Review of attachment 684075 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #684075 - Flags: review?(kvijayan) → review+
(Reporter)

Comment 3

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/37ad58ffe32b

Comment 4

5 years ago
Can this be closed or turned into a meta?
I'm thinking we can keep this open for fixing ongoing test failures that show up on x64 as development proceeds.
All green now.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.