814151 - Add a "camera-ready" or similar event to help tests ensure Camera's ready for tests to interact with

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

To help with testability / test reliability for our Camera tests [1], we'd love for a "camera-ready" event to be fired (or something similar), so we don't have to rely on arbitrary waits.

[1] https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/tests/test_camera.py

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Stephen: What issues are you seeing? The existing wait is not arbitrary - we're waiting for the video feed to be ready before attempting to capture a photo or video. If the video is not ready then you also wouldn't be able to capture manually, so a failure should be treated as a regression.

I have submitted a pull [1] to tidy up the wait code (but not change what we're waiting on), and added a wait for the video to be ready after switching mode from photo to video, which at least locally improved the reliability of the test.

Is there a chance the device attached to the Jenkins slave is not set up in such a way that it can reliably take photos? Without moving it, can you open the camera app and capture photo/video?

[1] https://github.com/mozilla/gaia-ui-tests/pull/63

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I filed this on behalf of Malini, who was looking into the camera tests' reliability at the time.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Are we still having issues? If not, can we close this?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

I filed this on proxy -- don't think we need it.  Someone else reopen if we do :-)