814204 - can't flick lockscreen open enough to hit the buttons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

marcia's comment from https://bugzilla.mozilla.org/show_bug.cgi?id=813525#c1 :

I have seem some issues when smoketesting the 2012-11-20 unagi nightly.

My main issue:

*Have gotten in states where I cannot select the buttons at all since when I flick up I cannot select the unlock button (keeps bouncing too low - buttons don't come up high enough to select)

Comment 1

[Dietrich Ayala (:dietrich)]

Requesting blocking. This is broken, not just a usability issue. It works fine after a reboot. I've noticed this after using the phone, then letting it sleep for a while, then re-awaken to this state.

Comment 2

[Borja Salguero [:borjasalguero]]

Weird thing... This bug is quite new, and it's only failing in Unagi (not in Otoro...) What has changed in these days?

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

This bug is occurred on otoro, too.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Marcia,

Could you explain more detail for this issue?
it looks like a duplicate of Bug 815016.

Comment 5

[Marcia Knous [:marcia]]

I just hit this again while testing. Here is what I see:

1. Set a passcode for the lockscreen.
2. Send yourself a text message
3. Try to unlock the phone
4. When I swipe I can never get the buttons up high enough to select them

I will try to get a video of the issue in a moment.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Marcia,

if you reproduce it again, could you click right bottom coroner on the screen? if this is a duplicate of Bug 815016, you will see browser app or feedback app launched.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Looks z-index of attentionScreen higher than lockscreen. I hit this when I received a call, and attention screen doesn't remove "displayed" class when end of call.

Did you make a call before you hit this issue?

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

We may need Steps to Reproduce. Some fixes has landed about how the dialer show/hide the call screen. And I wonder if those has fix this bug. But I would like a confirmation that it does not happen anymore, having something that prevent you to unlock your phone sounds really wrong...

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

I reproduced this two times yesterday. But I still don't know what's the consistent steps...
Here is my guess:
* Make a call
* Use the gallery, ev.me, .... or something makes phone busy.
* Under certain conditions, call screen will be killed accidentally. But attention screen module doesn't know that, so it keeps displaying behind the lockscreen.

Comment 10

[Dietrich Ayala (:dietrich)]

I can no longer reproduce this at all.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Alive Kuo [:alive] from comment #9)
> I reproduced this two times yesterday. But I still don't know what's the
> consistent steps...
> Here is my guess:
> * Make a call
> * Use the gallery, ev.me, .... or something makes phone busy.
> * Under certain conditions, call screen will be killed accidentally. But
> attention screen module doesn't know that, so it keeps displaying behind the
> lockscreen.

Oh that sounds logical. I can reproduce this with:
 - Open the dialer and call a USSD number #123# for example
 - adb shell to the device and run b2g-ps
 - kill -9 communications_pid

Actual result:
 - The attention screen content disappear but the user can not interact anymore with the screen

Expected result:
 - the attention screen content disappear but the user can still interact with the device


Marcia can you confirm that this is the right bug by using the steps to reproduce you add in #c5 and when the screen does not respond try to long press the power button and see if you can interact with the menu that pops up (Turn on airplane mode, Silence incoming calls, restart phone, power off) ?

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Vivien Nicolas (:vingtetun) from comment #11)
> (In reply to Alive Kuo [:alive] from comment #9)
> > I reproduced this two times yesterday. But I still don't know what's the
> > consistent steps...
> > Here is my guess:
> > * Make a call
> > * Use the gallery, ev.me, .... or something makes phone busy.
> > * Under certain conditions, call screen will be killed accidentally. But
> > attention screen module doesn't know that, so it keeps displaying behind the
> > lockscreen.
> 
> Oh that sounds logical. I can reproduce this with:
>  - Open the dialer and call a USSD number #123# for example
>  - adb shell to the device and run b2g-ps
>  - kill -9 communications_pid
> 
> Actual result:
>  - The attention screen content disappear but the user can not interact
> anymore with the screen
> 

No matter this is Marcia's STR or not, we should fix this.

First, in the UI part. Attention screen should monitor mozbrowsererror event with fatal type(I assume it would be fired to the attention screen's iframe. If we don't have it, ask platform support).
Second, the platform part. Find out why call screen is killed? Because of OOM or itself crashes? I tried many times but it is not easy to reproduce the crash(I don't use adb to kill. It happened naturally). But I don't think the dialer should be killed anyway...it's the core of the entire phone. Think about crashing when on a call....too bad than you cannot unlock the device.

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: patch v1

this patch can avoid unresponsive phone when dialer is crash.

I tested apps related with attention screen like call, bluetooth transfer, alarm. all looks good. Please let me know if I missing something which need to test.

thanks!

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 687629 [details] [diff] [review]
patch v1

I would recommend remove the |error| function and let |close| handle the mozbrowsererror event.

>@@ -32,6 +32,7 @@ var AttentionScreen = {
>     window.addEventListener('mozbrowserclose', this.close.bind(this), true);
>     window.addEventListener('keyboardchange', this.resize.bind(this), true);
>     window.addEventListener('keyboardhide', this.resize.bind(this), true);
>+    window.addEventListener('mozbrowsererror', this.error.bind(this), true);
> 
>     this.bar.addEventListener('click', this.show.bind(this));
>     window.addEventListener('home', this.hide.bind(this));
>@@ -133,6 +134,13 @@ var AttentionScreen = {
>     window.focus();
>   },
> 
>+  error: function as_error(evt) {
>+    // app is forced close. avoid unresponsive device with this.close()
Remove this comment
>+    if (evt.detail.type === 'fatal') {
>+      this.close(evt);
>+    }

if (evt.detail.type !== 'fatal')
  return;

this.close(evt);

>+  },
>+
>   show: function as_show() {
>     this.attentionScreen.style.MozTransition = 'none';
>     this.attentionScreen.classList.remove('status-mode');
>-- 
>1.7.9.5
>

Comment 15

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: patch for commit

Comment 16

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.

Comment 17

[Marcia Knous [:marcia]]

I haven't seen this issue again on my unagi device since the fix landed.

Comment 18

[Rebecca Billings [:rbillings]]

Unable to repro on the 12/28 unagi build.