814230 - Warn on close with multiple tabs open not working in FF 17.0

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[kimmersly]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Updated to FF 17.0.  Closed FF expecting a warning that multiple tabs were open.
Didn't get one ((FF just closed instantly).

Tried with a clean profile, and NO add-ons.   Same incorrect behavior.   And yes, the
option to warn on close IS on.



Actual results:

No warning on closing.  FF just closed.




Expected results:

Should have had a warning/confirmation window pop up.

Comment 1

[Matthias Versen [:Matti]]

Are your tabs restored if you open Firefox ?
in that case this is intended : bug 348471

Comment 2

[kimmersly]

(In reply to Matthias Versen (Matti) from comment #1)
> Are your tabs restored if you open Firefox ?
> in that case this is intended : bug 348471

If you mean are the tabs restored on a subsequent reopening of FF, then yes, they are.

However, NO warning pop-up asking for confirmation was given even though the options checkbox IS checked requesting that such warning/confirmation be given.
And as has been done as long as I can recall (since at least FF2.x).

Are you saying that said option no longer has any meaning, and that FF has once
again removed a feature that (some) users use and want?

/kim

Comment 3

[mjh563]

(In reply to kimmersly from comment #2)
> If you mean are the tabs restored on a subsequent reopening of FF, then yes,
> they are.

Why do you want a warning then? If the tabs can be restored just by opening Firefox again, isn't a warning about closing them a bit pointless?

If you really want to see it though, go to Tools > Options > General and change "When Firefox starts" to "Show my home page".

Comment 4

[Matthias Versen [:Matti]]

Attachment: Screenshot

Please ignore my comment#1.
It looks like that it works as expected as you can see in my screenshot

Comment 5

[kimmersly]

(In reply to Matthias Versen (Matti) from comment #4)
> Created attachment 684533 [details]
> Screenshot
> 
> Please ignore my comment#1.
> It looks like that it works as expected as you can see in my screenshot

Yes, that is exactly what is supposed to happen, and has been happening for me until I updated to FF 17.0 a couple nights ago.  It is NOT happening now.  Hence this bug report.

And to clarify, the lack of the warning is happening with my usual set of add-ons, OR on a clean profile with NO add-ons.

/kim

Comment 6

[Matthias Versen [:Matti]]

I can only tell you that it's working for me with Firefox17 on Windows7 and a new profile. I don't understand that it doesn't work for you with a new profile.

Comment 7

[kimmersly]

Thanks for checking, and I'm glad it is working for you.  All I can say is:

It was working just fine in FF 16.x (and prior) with my add-ons.

I allowed the proffered update to 17.0 to proceed.  It installed cleanly, with no hiccups, errors, or any problem.

Restarted FF (now at 17.0).

When I closed it for the night with 30+ tabs open, I got NO warning.

Tried it again ... same non-warning at the close.

Tried it with a clean, NO add-ons profile.  Again NO warning at the closing.

And so ... here I am ...

/kim

Comment 8

[mjh563]

Kim, could you check the setting I mentioned in comment 3? What is "When Firefox starts..." set to?

Comment 9

[Matthias Versen [:Matti]]

"Show my homepage". 
In case you let firefox restore the tabs on startup no warning should happen (bug 663699)
My comment#1 is correct, sorry for the confusion.

Do you used tabmixplus (AFAIK currently incompatible with FF17) with Firefox16 ?

Comment 10

[kimmersly]

Yes, I do use TMP, but the FF error happens with NO add-on enabled, as well.

FF 17.0 is NOT behaving as previous revs did (and is certainly NOT a welcome
change).

First I've heard of FF 17.0 being incompatible with TMP ... I shall inform them of such (though the add-on compatibility checker that runs on an update restart did NOT find a problem with any add-ons but Cooliris [which I have DISabled, anyway]).

/kim

Comment 11

[kimmersly]

(In reply to mjh563 from comment #8)
> Kim, could you check the setting I mentioned in comment 3? What is "When
> Firefox starts..." set to?

Hmmmm ... I did reply to comment #8, but it seems not to have shown up ...

It is set to "Show my windows and tabs from last time", which has been working just fine, and is what I want.

Comment 12

[Matthias Versen [:Matti]]

>FF 17.0 is NOT behaving as previous revs did
You are wrong here: Firefox10 as example behaves identical to Firefox17 in this case.

No warning is shown if you close the last window with multiple tabs and your startup setting is to restore the tabs.

I can only explain the difference that you are seeing with an addon like TMP that provided the warning and isn't working properly.

I'm closing this report as invalid because the behavior that your get is intended

Comment 13

[kimmersly]

(In reply to Matthias Versen (Matti) from comment #12)
> >FF 17.0 is NOT behaving as previous revs did
> You are wrong here: Firefox10 as example behaves identical to Firefox17 in
> this case.
> 
> No warning is shown if you close the last window with multiple tabs and your
> startup setting is to restore the tabs.
> 
> I can only explain the difference that you are seeing with an addon like TMP
> that provided the warning and isn't working properly.
> 
> I'm closing this report as invalid because the behavior that your get is
> intended

As I told you several times ... it does NOT work properly with NO add-ons.  NO TabMixPlus.  Just a bare, clean profile.

Comment 14

[mjh563]

(In reply to kimmersly from comment #13)
> As I told you several times ... it does NOT work properly with NO add-ons. 
> NO TabMixPlus.  Just a bare, clean profile.

If you have it set to "Show my windows and tabs from last time" and you don't get a warning, then it's working as expected. That setting means that the warning will *not* be shown (see bug 348471), which is what you say happens. 

So you're experiencing the expected behaviour, as far as I can see.

Comment 15

[kimmersly]

(In reply to mjh563 from comment #14)
> 
> That setting means that
> the warning will *not* be shown (see bug 348471), which is what you say
> happens. 

I see. The setting that says "Warn me when closing multiple tabs" (on the
Options > Tabs page), really means "the warning will *not* be shown".

As comment # 13 in the bug report you ref says: "This is a shame that a choice has been taken away from user ..."

Comment 16

[Matthias Versen [:Matti]]

>The setting that says "Warn me when closing multiple tabs" (on the
>Options > Tabs page), really means "the warning will *not* be shown".

With "Warn me when closing multiple tabs" enabled you should get a warning if you close a window with more than one tab open except if it's the last window.
In case of the last window the warning will be only shown if your startup setting doesn't restore the tabs.

Comment 17

[kimmersly]

The option says (and I quote) "Warn me when closing multiple tabs".

It says nothing about exceptions.  It is not "grayed-out" if there is another
option set which would override it (which YOU say is the "expected behaviour").

You have improperly closed this bug report (IMNSHO), as the issue is NOT resolved.

Please fix the option so that it does what it purports to do, or remove it entirely since it is incorrect and misleading, as stated.