814285 - Simplify imagelib's networking code and let necko handle complexity

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Right now imagelib does entirely too much micromanaging of network connections, which results in code that's hard to understand and difficult to work with.

This is a metabug to track both the underlying issues in necko that led to imagelib taking the approach it has taken, and the fixes and refactoring that can take place in imagelib once those issues are fixed.

Comment 1

[Seth Fowler [:seth] [:s2h]]

(CC'ing some relevant parties)

Comment 2

[Seth Fowler [:seth] [:s2h]]

This was the initial issue that motivated me to open this bug:

- We do coalescing of requests at a high level in imagelib. (For example, we remember when a cache entry is being validated, and have special code to assign new imageRequestProxies to an validation-related network request.) This should be handled at a low level in necko; we should be able to have multiple concurrent requests to the same URI and get back the same data instead as it comes in (instead of later requests blocking until the first request is completely finished). This is what bug 446876 is about.

I understand from talking to some of the necko developers that there are issues with the way that imagelib uses the necko APIs; apparently it doesn't correctly follow their contracts. I understand this is causing issues in various areas - for example I'm told that necko now has a notion of apps that doesn't map well onto imagelib. Hopefully we can get the relevant bugs for those problems linked here as well.

I'm sure these aren't the only issues. Hopefully we can take this opportunity to get all of the necko-related issues in imagelib together and start getting them tackled.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Seth Fowler [:seth] from comment #2)
> I'm told that necko now has a notion of apps
> that doesn't map well onto imagelib. Hopefully we can get the relevant bugs
> for those problems linked here as well.

Is there a bug for this already? This is a potential basecamp blocker and I'd like to learn more about it.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Brian Smith (:briansmith, was :bsmith; NEEDINFO? for response) from comment #3)
> (In reply to Seth Fowler [:seth] from comment #2)
> > I'm told that necko now has a notion of apps
> > that doesn't map well onto imagelib. Hopefully we can get the relevant bugs
> > for those problems linked here as well.
> 
> Is there a bug for this already? This is a potential basecamp blocker and
> I'd like to learn more about it.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:aosmond, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.