Don't prompt for missing permissions (UNKNOWN_ACTION)

RESOLVED FIXED in Firefox 18

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pauljt, Assigned: gwagner)

Tracking

16 Branch
mozilla20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
DeviceStorage should only be able to be requested by Privileged & Certified Apps. (as per https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Akyz_Bqjgf5pdENVekxYRjBTX0dCXzItMnRyUU1RQ0E#gid=0) 

Currently on Firefox OS (both desktop and device), even web content can request the permission by accessing the API. See http://dogs.creativemisuse.com/ and try clicking the"add an image" or "read music dir" buttons.

Note that this issue doesn't seem to be present on Firefox desktop, even when the device.storage.enabled pref is true. (tested in mac 18.0a2)

This will be security issue once privileged apps has landed, so should be blocking basecamp I think.
blocking-basecamp: ? → +
(Assignee)

Comment 1

5 years ago
Created attachment 685314 [details] [diff] [review]
patch
(Assignee)

Updated

5 years ago
Attachment #685314 - Flags: review?(jonas)
(Assignee)

Updated

5 years ago
Summary: DeviceStorage should be restricted to Privileged Apps → Don't prompt for missing permissions (UNKNOWN_ACTION)
(Assignee)

Comment 2

5 years ago
We shouldn't treat missing permissions as prompt permissions.
I think I get the right behavior now for http://dogs.creativemisuse.com/

Paul, can you test as well?
Attachment #685314 - Flags: review?(jonas) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/448ae175d6b9

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/448ae175d6b9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
https://hg.mozilla.org/releases/mozilla-aurora/rev/306c951213c6
https://hg.mozilla.org/releases/mozilla-beta/rev/b17670cd809c
status-firefox18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.