814344 - Add-ons Bar button customization not sticky across sessions

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Brian King [:kinger]]

STR:

1. Install the ACR
2. Open Customize and drag the jigsaw icon from the Add-ons Bar into it. Click Done to close.
3. Restart Firefox

Expected:
Icon is not in the Add-ons bar

Actual:
Icon has reappeared in the Add-ons Bar

Comment 1

[Brian King [:kinger]]

This appears to be an SDK bug. I tried with 2 other add-ons that put icons there, namely Instagram for Firefox and Mozilla Reps Companion, and both had the same result.

Comment 2

[Brian King [:kinger]]

Attachment: Obscured icon in Customize

And related (though it probably be a separate bug), the icon when dragged into Customize does not appear properly. In XUL add-ons the way to do this was to over some CSS into the Customize window. I'm not sure if there is some best practice add-on authors need to follow here or if it is an SDK issue.

Comment 3

[Brian King [:kinger]]

Erik,

Have you come across this?

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Brian King [:kinger] from comment #3)
> Erik,
> 
> Have you come across this?

Nope, this seems to be working for me.. although someone has posted a similar issue in the mailing list just a day or two ago so there must be something going on..

Comment 5

[Jeff Griffiths (:canuckistani) (:⚡︎)]

FYI I looked into the mailing list issue, I *think* it is caused by having a second extension installed that uses a very old ( pre-1.0 ) version of the SDK.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Brian King [:kinger] from comment #0)
> STR:
> 
> 1. Install the ACR
> 2. Open Customize and drag the jigsaw icon from the Add-ons Bar into it.
> Click Done to close.
> 3. Restart Firefox
> 
> Expected:
> Icon is not in the Add-ons bar
> 
> Actual:
> Icon has reappeared in the Add-ons Bar

Thanks for this, I can reproduce the issue.

Comment 7

[Brian King [:kinger]]

FYI the SDK version the ACR 2.0 is built with is 1.11

Comment 8

[Alexandre Poirot [:ochameau]]

This bug will be fixed by patch submitted in bug 847309 and isn't there yet as it depends on some platform tweaks.

Comment 9

[Matteo Ferretti [:zer0] [:matteo]]

I think we can close it as INVALID, both because probably was fixed by a patch from Gijs, but mainly because we do not have Add-on Bar anymore.