[gonk] remove default value of master volume setting

RESOLVED FIXED

Status

Firefox OS
General
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rlin, Assigned: rlin)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

After gaia/gecko implemented the control volume by stream type, this default master volume should be eliminated.
Assignee: nobody → rlin
Summary: [gonk] remove default master volume setting → [gonk] remove default value of master volume setting
Created attachment 684550 [details] [diff] [review]
patch 1

When gaia change to use SetStreamVolumeIndex API,
The master volume would keep in 0.5.
Attachment #684550 - Flags: review?(mwu)
Created attachment 685015 [details] [diff] [review]
patch 2

remove audioManager object would cause headset detect error.
Attachment #684550 - Attachment is obsolete: true
Attachment #684550 - Flags: review?(mwu)
Attachment #685015 - Flags: review?(mwu)

Comment 4

6 years ago
Comment on attachment 685015 [details] [diff] [review]
patch 2

I think vingtetun understands this volume code better.
Attachment #685015 - Flags: review?(mwu) → review?(21)
Comment on attachment 685015 [details] [diff] [review]
patch 2

Review of attachment 685015 [details] [diff] [review]:
-----------------------------------------------------------------

That make sense. This code was here until there is a way for the content to set a default value. Now there is one.
Attachment #685015 - Flags: review?(21) → review+
Created attachment 685942 [details] [diff] [review]
checkin-patch

check-in patch
Attachment #685015 - Attachment is obsolete: true
Whiteboard: checkin-needed
Now we use setStreamVolumeIndex api to control steam volume instead of using setMasterVolume, this 0.5f hard-code value would affect the android audioflinger master volume setting. (default = 1.0f), so we need to remove it.

Comment 8

6 years ago
Dear Joe,

Since this reduced the volume level to 1/2 generally, user will complain the volume too small.
I think it would be blocking-basecamp+.
blocking-basecamp: --- → ?
Flags: needinfo?(jcheng)
given that this reduce the volumne level to 1/2 of what the resulting volume should be for everything. blocking-basecamp+
blocking-basecamp: ? → +
Flags: needinfo?(jcheng)
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/99233fe0b2b3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/fdd163ca5311
https://hg.mozilla.org/releases/mozilla-beta/rev/43b16cfb2817
status-firefox18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
You need to log in before you can comment on or make changes to this bug.