Clear browsing history and clear cookies and stored data confirmations should have class=danger because they involve deleting info, so user must be warned
5 years ago
Created attachment 779591 [details] [review] nsure clear data dialogs have warning UI
The test plan for this is to follow the user interaction and ensure that the relevant data is cleared, I dont think we want to specifically test that button has a danger class, but it wouldnt be hard to add
Comment on attachment 779591 [details] [review] nsure clear data dialogs have warning UI I think there's an opportunity to split Browser Settings out into a separate module in a re-factor but we can do that later. r+me with a few nits (see GitHub)
forgot to mention, nits were addressed
"mozilla-central" gecko revision="a4c1961bf723" "gecko.git" "e1ec7bf56f833462f1f317defc6b05e697911b06" "gaia.git" revision="c7272f0b45c9fdac9d551828987e343300e87bf6" Build ID: 2013-07-25-03-02-11 MC/master build Unagi Buttons are now red for the "ok" button to delete instead of blue ; seems to be functioning correctly for 0, 1, or more bookmarks/cookies.
Forgot to mention that I checked cancel as well. Seems ok. There are test cases testing the functionality of these buttons, so I think we're ok for test cases.
Uplifted due to Bug 941489. v1.1.0hd: 5b4af0ffaae2956241842f9f146f15347dae3ad0