814441 - Email text has no formatting applied

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Ian Barlow (:ibarlow)]

Steps to reproduce
1. Open email app
2. Tap on an email
3. Read email

Expected results
1. Email text is a legible size.
2. Email is formatted in a way that looks consistent with the rest of the OS

Actual results
The text in the body of emails has no styling applied, and is formatted at a size that is too small to comfortably read.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Text is not legible. We need to update the CSS, the body text size should be 1.9rem with the line height of 2.6rem.

Comment 2

[steve]

see link

https://www.dropbox.com/s/ummz02cgfmp90l2/10%20Email_5_Recipients.png

Comment 3

[Josh Carpenter [:jcarpenter]]

Flagging for uxbranch.

Comment 4

[Josh Carpenter [:jcarpenter]]

Any progress here?

Comment 5

[Steve Chung [:steveck]]

Attachment: Patch for applying text style to plain text mail

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 699072 [details]
Patch for applying text style to plain text mail

You've applied the requested style only to the msg-body-content, which is one of many mutually exclusive styles we apply based on quoting analysis.  I think we wanted the quoted text to share the same font characteristics.

As such, I think it makes more sense to put the styling on ".msg-body-container" instead, which will be inherited by the quoted styles.  This does not appear to interfere with HTML part display.

r=asuth for doing that instead.

Comment 8

[Steve Chung [:steveck]]

Thanks for the suggestion. I've modified the style. Although UX has tagged these issues as 'BerlinWW' and they might have higher priority than other UX bug, do we still need approval to land these issue with tag?

Comment 9

[Steve Chung [:steveck]]

Comment on attachment 699072 [details]
Patch for applying text style to plain text mail

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 10

[Ben Francis [:benfrancis]]

Comment on attachment 699072 [details]
Patch for applying text style to plain text mail

CSS-only change. approval-gaia-master+

Comment 11

[Deepa Subramanian]

Verified on Unagi device Build ID: 20130112070202 v1.o