814444 - Remove now-useless TRAVERSE_NATIVE_BEGIN and UNLINK_BEGIN_NATIVE macros

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: kill _NATIVE macros

Since bug 806279 they are just dupes for the non-_NATIVE macro, and we forgot to eliminate them in bug 807437, and now they are causing confusion in bug 811371, confusing people into believing they they can't use the helper macros with native types because the helper macros don't use the _NATIVE macros.

One review is enough, whoever of Smaug or Mccr8 does it first.

Comment 1

[Andrew McCreight [:mccr8]]

Comment on attachment 684445 [details] [diff] [review]
kill _NATIVE macros

Review of attachment 684445 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

There's still NS_IMPL_CYCLE_COLLECTION_UNLINK_0 and NS_IMPL_CYCLE_COLLECTION_UNLINK_NATIVE_0. Probably okay to redefine the first to be
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN
...and delete the second, renaming its few uses. You can fix that if you want in this patch, or I'll just file a followup bug.

Comment 2

[Andrew McCreight [:mccr8]]

That second NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN should be NS_IMPL_CYCLE_COLLECTION_UNLINK_END of course. ;)

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32c109fec34f

Please do the follow-up :-)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32c109fec34f