814447 - Progressive update cancelling uses incorrect information

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Chris Lord [:cwiiis]]

Progressive updates are only cancelled if we've sent a more recent displayport, and always when the resolution has changed.

We use the incorrect resolution when checking so that sometimes this would cause cancelling when it shouldn't (this was most prevalent in single-screen games).

Also, we don't re-check that the displayport is current in low-res drawing, meaning we can spend time drawing stale low-res content that could otherwise be spent drawing high-res content.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix progressive draw cancelling using incorrect values

I use the zoomFactor from the viewport instead of the resolution from the displayport, as it's possible that the displayport resolution is out-of-date due to setFirstPaintViewport being called without any scrolling afterwards (so it'll be permanently out of date if the page isn't larger than the screen).

It's ok to carry on using the displayport below, as adjustViewport would be called on the new page load and the displayport will be at 0,0, so the viewport will definitely be inside it. Rotation will be ok, as that calls adjustViewport, which calculates a new displayport using up-to-date values.

It might be prudent to update the displayport resolution in setFirstPaintViewport, but I don't think the displayport is used anywhere else in this way, and setFirstPaintViewport is on the wrong thread to make such a change trivially.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 684449 [details] [diff] [review]
Fix progressive draw cancelling using incorrect values

Review of attachment 684449 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/13a335d277d9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13a335d277d9