Closed Bug 814455 Opened 12 years ago Closed 11 years ago

Intermittent test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - *** Error compiling shader '[object WebGLShader]':(3) : error C7538: OpenGL does not allow 'highp' after 'inout'

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Version:
19 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20

People

(Reporter: emorley, Assigned: bjacob)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on Android])

Attachments

(3 files)

disable glsl-function.html on android
614 bytes, patch
jgilbert
: review+
Details | Diff | Splinter Review
install skipped_tests_android.txt
703 bytes, patch
jgilbert
: review+
Details | Diff | Splinter Review
skip all failing glsl tests on android
2.04 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review 
Android Armv6 Tegra 250 mozilla-central opt test mochitest-1 on 2012-11-22 04:40:30 PST for push 3b71d63eafd5

slave: tegra-265

https://tbpl.mozilla.org/php/getParsedLog.php?id=17275713&tree=Firefox

{
41329 INFO TEST-INFO | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] (WebGL mochitest) Starting test page
41330 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - *** Error compiling shader '[object WebGLShader]':(3) : error C7538: OpenGL does not allow 'highp' after 'inout'
(6) : error C7538: OpenGL does not allow 'highp' after 'inout'

41331 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - *** Error loading shader '[object WebGLShader]':INVALID_VALUE
41332 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - Error in program linking:
41333 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - getError expected: NO_ERROR. Was INVALID_VALUE : no errors from draw
41334 INFO TEST-PASS | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test passed - getError was expected value: NO_ERROR : no errors from draw
41335 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - images are different
41336 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - *** Error compiling shader '[object WebGLShader]':(3) : error C7538: OpenGL does not allow 'highp' after 'inout'
(6) : error C7538: OpenGL does not allow 'highp' after 'inout'

41337 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - *** Error loading shader '[object WebGLShader]':INVALID_VALUE
41338 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - Error in program linking:
41339 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - getError expected: NO_ERROR. Was INVALID_VALUE : no errors from draw
41340 INFO TEST-PASS | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test passed - getError was expected value: NO_ERROR : no errors from draw
41341 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - images are different
41342 INFO TEST-KNOWN-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | [conformance/glsl/functions/glsl-function.html] Test failed - *** Error compiling shader '[object WebGLShader]':(3) : error C7538: OpenGL does not allow 'highp' after 'inout'
(6) : error C7538: OpenGL does not allow 'highp' after 'inout'
...
and so on
}
Benoit, do you have any idea what caused this? These failures hang the TBPL UI (even with the newish measures to only show the first N failures/bug suggestions), so have more of an impact than the number of TBPLbot comments in this bug would imply.

Cheers :-)
Flags: needinfo?(bjacob)
I have no idea what caused this, let me look at what happened around that date...
Flags: needinfo?(bjacob)
Looked at changesets around these dates; nothing obvious. But we now have the ability to easily disable a WebGL test on Android, so let's do that.
Also, these error message seem to come straight from the Tegra driver: I can't see them in ANGLE. This further indicates that it's plausible that this would be an issue with the slaves rather than an issue with our code.
Assignee: nobody → bjacob

        Attachment #688743 -
        Flags: review?(jgilbert)

    
    

    
      
  

    
    

    
      
  

        Attachment #688743 -
        Flags: review?(jgilbert) → review+

    
  
Whiteboard: [test disabled on Android][leave open]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
This is still occurring after the disable patch landed, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17711791&tree=Mozilla-Inbound

    
    

    
  
The logs show that there are two problems:
 - the skipping is not actually done at all, for any pages in the skip list
 - there are more failing GLSL pages than just this one. They are already in failing_. Need to move them all to skipped_.

    
    

    
  


  
Forgot the makefile change to install this file... sorry.

        Attachment #689833 -
        Flags: review?(jgilbert)

    
    

    
  


  
We'll re-enable them after the next Android test hardware/driver refresh, I guess.

        Attachment #689835 -
        Flags: review?(jgilbert)

        Attachment #689833 -
        Flags: review?(jgilbert) → review+

    
    

    
  
Comment on attachment 689835 [details] [diff] [review]
skip all failing glsl tests on android

Review of attachment 689835 [details] [diff] [review]:
-----------------------------------------------------------------

This is a lot to skip. We need these tests.
We should at the very least dump the problematic shader sources so we're sure it wasn't an ANGLE update or something which is messing things up.

        Attachment #689835 -
        Flags: review?(jgilbert) → review+

    
    

    
  
(In reply to Jeff Gilbert [:jgilbert] from comment #55)
> Comment on attachment 689835 [details] [diff] [review]
> skip all failing glsl tests on android
> 
> Review of attachment 689835 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is a lot to skip. We need these tests.
> We should at the very least dump the problematic shader sources so we're
> sure it wasn't an ANGLE update or something which is messing things up.

What we can do is only land the first patch for now and see if that's enough. I don't actually know if we need to skip all these tests.

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
How is that possible. Comment 67 and 68 are again on inbound. The test we're trying to skip is still not being skipped.

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
(In reply to Benoit Jacob [:bjacob] from comment #70)
> How is that possible. Comment 67 and 68 are again on inbound. The test we're
> trying to skip is still not being skipped.

:-(

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
  
Blocks: 822299

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
So the good news is that the failures on central and inbound don't fail in the page that we skip (glsl-function.html) so the skipping works. The bad news is that we really have to skip the other pages:

$ zcat a.gz | grep 'OpenGL does not allow' | cut -d '[' -f 2 | cut -d ']' -f 1 | grep conformance | sort | uniq
conformance/glsl/functions/glsl-function-abs.html
conformance/glsl/functions/glsl-function-ceil.html
conformance/glsl/functions/glsl-function-clamp-float.html
conformance/glsl/functions/glsl-function-clamp-gentype.html
conformance/glsl/functions/glsl-function-cross.html
conformance/glsl/functions/glsl-function-distance.html
conformance/glsl/functions/glsl-function-dot.html
conformance/glsl/functions/glsl-function-faceforward.html
conformance/glsl/functions/glsl-function-floor.html
conformance/glsl/functions/glsl-function-fract.html
conformance/glsl/functions/glsl-function-length.html
conformance/glsl/functions/glsl-function-max-float.html
conformance/glsl/functions/glsl-function-max-gentype.html
conformance/glsl/functions/glsl-function-min-float.html
conformance/glsl/functions/glsl-function-min-gentype.html
conformance/glsl/functions/glsl-function-mix-float.html
conformance/glsl/functions/glsl-function-mix-gentype.html
conformance/glsl/functions/glsl-function-mod-float.html
conformance/glsl/functions/glsl-function-mod-gentype.html
conformance/glsl/functions/glsl-function-normalize.html
conformance/glsl/functions/glsl-function-reflect.html
conformance/glsl/functions/glsl-function-sign.html
conformance/glsl/functions/glsl-function-smoothstep-float.html
conformance/glsl/functions/glsl-function-smoothstep-gentype.html
conformance/glsl/functions/glsl-function-step-float.html
conformance/glsl/functions/glsl-function-step-gentype.html

    
    

    
  
And those are exactly the ones from the patch that we decided not to land yet. So it is time to land it.

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
  
This is not happening anymore on central/inbound, so the disabling was effective.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [test disabled on Android][leave open] → [test disabled on Android]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: