814461 - [Aero] Themes cannot change window border

Status: RESOLVED INVALID

(Thunderbird :: OS Integration, defect)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

There is no (or at least, I don't know any) way to change a window's "chromemargin" attribute from a Theme.

Steps I tried:
- Inject scripts via overlaying (-> overlaying is disabled for themes)
- Adding a default preferences file with the mail.tabs.drawInTitlebar preference(-> not working)
- Use CSS to influence the glass of the window (-> I haven't been able to find something bringing the borders and the title with icon, etc back)
- Remodel the Window border in CSS (-> no way to restore title or icon, window buttons and dragging the window works fine)

I fill this bug because I recived many complaints about me not providing a TB17-compartible version of my theme "Ignore Aero". I know that there is an easy workaround by setting mail.tabs.drawInTitlebar to false manually.

I'm looking forward to feedback if there is a way I missed or on the way window borders should get handled from the theme's point of view.

Comment 1

[Axel Grude [:realRaven]]

(In reply to rsjtdrjgfuzkfg from comment #0)

> I fill this bug because I recived many complaints about me not providing a
> TB17-compartible version of my theme "Ignore Aero". I know that there is an
> easy workaround by setting mail.tabs.drawInTitlebar to false manually.
> 
> I'm looking forward to feedback if there is a way I missed or on the way
> window borders should get handled from the theme's point of view.

While I do not know whether it is actually possible to do this, I am suffering from deterioration in my Windows environments as well, as I am a long time Windowblinds user. I think the workaround with the drawInTitlebar is the best, or alternatively having the menu on the titlebar (and not the tabs).

I have written an extension that adds a button for toggling this setting to the toolbar palette, it is called "Titlebar Tabs Cleaner" and is hosted on AMO:

https://addons.mozilla.org/thunderbird/addon/titlebar-cleaner/

Maybe you can point your users to this extensions to make it easier for them to toggle the setting, as handling about:config is not everybody's cup of tea.

cheers
  Axel

Comment 2

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

@Axel:
I don't think that AMO will review themes which do not display window buttons at all (which I fully understand, I wouldn't review such things either...), and thus I don't think I can continue the theme with such a note. I can not even address users installing from the integrated search (thus not seeing the description).

The Add-on solution I thought of would be a required add-on which forces the config, as this is the only way to not bring users to an inconsistent state. While I could write the add-on, publishing a theme which requires an add-on sounds not reviewable for me... and I don't think that all users would be able to install it then.

Comment 3

[Axel Grude [:realRaven]]

(In reply to rsjtdrjgfuzkfg from comment #2)
> 
> The Add-on solution I thought of would be a required add-on which forces the
> config, as this is the only way to not bring users to an inconsistent state.
> While I could write the add-on, publishing a theme which requires an add-on
> sounds not reviewable for me... and I don't think that all users would be
> able to install it then.
Well there are addons that have a mix of a theme + (config) extension bundled, and it is also possible to execute JavaScript from a theme. You should probably ask the reviewers' mailing list [e-mail] to find out whether force-changing a system setting as part of the theme install would be feasible to them. As a minimum you would be expected to restore the old state of this settings on uninstalling your theme.

Comment 4

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

@Axel:
You have and example for JS in themes? That would allow me to manupulate the window directly, probably there is a way which will not harm the setting at all. However I thought that is not possible due to security restrictions?

Comment 5

[Axel Grude [:realRaven]]

(In reply to rsjtdrjgfuzkfg from comment #4)
> @Axel:
> You have and example for JS in themes? That would allow me to manupulate the
> window directly, probably there is a way which will not harm the setting at
> all. However I thought that is not possible due to security restrictions?

UNfortuinately, I don't. :( but Kris Maglione, one of the senior AMO Reviewers has mentioned it, so the best way to find out is to ask him on IRC:

irc.mozilla.org #amo-editors

just have a lookout for John-Galt.

Comment 6

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

I found and used a workaround, didn't know that it is possible to upload type 32 add-on bundles as themes on AMO (note: only with internalName set in the surrounding install.rdf, even though the validator dislikes that with a warning).

@Axel: there is no intended way to execute JS from Themes, at least that's what everyone in irc says. And I'm quite sure they're right ;)

Still interested if somebody nows a pure theme solution for this issue... switching to minor priority as a workaround is found.

Comment 7

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Sadly the workaround is rejected, as an add-on is not allowed to be hidden, even if it is part of a theme. I agree that my initial workaround is not nice - and search again for a solution.
Making the add-on visible will not work as if the user is able to disable or uninstall the add-on, the design issues would be visible again - and I'm sure the regular user does not see a relation between his window looking ugly and the add-on he disabled or uninstalled.

It is not allowed to prevent the user from uninstalling or disabling the add-on part when hosting on AMO ("is it ok to remove the uninstall/disable button for the add-on part?" "No." - Kris Maglione, via IRC#amo-editors).

So this bug again is a blocker for my theme, thus restoring normal priority. Alternatively, if somebody knows a safe alternative to AMO for hosting themes?

Comment 8

[Wayne Mery (:wsmwk)]

Is this even allowed in current or future versions?

Comment 9

[Richard Marti (:Paenglab)]

With TB 68 full themes don't work any more.