814479 - tabs are too tall

Status: RESOLVED DUPLICATE of bug 824651

(Firefox :: Theme, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

on win8-desktop tabs look odd. mostly just too tall, but I think there is also some
padding missing.

Comment 1

[Jim Mathies [:jimm]]

Is this on a device that supports touch? We increase the size of tabs on these devices.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes. But tabs looked odd, and certainly uglier than in IE10.

Comment 3

[Jim Mathies [:jimm]]

(In reply to Olli Pettay [:smaug] from comment #2)
> Yes. But tabs looked odd, and certainly uglier than in IE10.

Can you post a screen shot? What you see might be by design or it might be a bug.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I don't have any Win8 devices. I just went to a shop and installed elm to few laptops for testing :)

Comment 6

[Brandon Shea]

I'm seeing this on a Windows 8 laptop which does not support touch, so I'm not sure if it's specific to touch-enabled devices.

Comment 7

[Brandon Shea]

Attachment: Screenshot of Windows 8 tabs

Comment 8

[Brandon Shea]

I can confirm that this bug is still present in Firefox 18.0.1.

Comment 9

[Brandon Shea]

This bug only seems to be present on my laptop. My desktop PC running Windows 8 displays tabs correctly.

Comment 10

[Jim Mathies [:jimm]]

(In reply to Brandon Shea from comment #9)
> This bug only seems to be present on my laptop. My desktop PC running
> Windows 8 displays tabs correctly.

Does your laptop support touch? We expand the height of certain elements on machines with touch input displays.

Comment 11

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #10)
> (In reply to Brandon Shea from comment #9)
> > This bug only seems to be present on my laptop. My desktop PC running
> > Windows 8 displays tabs correctly.
> 
> Does your laptop support touch? We expand the height of certain elements on
> machines with touch input displays.

Oh, sorry, you already answered that question.

Comment 12

[Jim Mathies [:jimm]]

Felipe, any idea as to how this might get triggered on non-touch hardware?

Comment 13

[:Felipe Gomes (needinfo for replies!)]

Do you have a Wacom or other pen-input hardware connected? Or anything unusual about your hardware setup?

This is the only thing that triggers that mode: http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsLookAndFeel.cpp#44 , so it must be Windows reporting it incorrectly for some reason.

But it's worth noting that just yesterday we landed on inbound bug 824651 which got rid of all this resizing for non-Metro desktop Firefox, so this effect will be fixed in tomorrow's nightly.

But it would still be interesting to discover why Brandon's computer is reporting it wrong..

Comment 14

[Brandon Shea]

No, I don't have any Wacom/pen/touch input devices installed. The only pointing devices installed on this computer are the Lenovo UltraNav touchpad/pointing stick, keyboard, and a Kensington trackball mouse.

Let me know if there's any system info I can provide to help isolate the problem.

Comment 15

[Nikhil Johny]

hi, i am a noob, how can i get started to fix this bug

Comment 16

[Matt Brubeck (:mbrubeck)]

Since the original problem from comment 0 is fixed, I'm resolving this bug.  It's probably worth filing a separate bug for the mis-detection of Brandon's laptop as a touch-capable device.