Closed Bug 814565 Opened 11 years ago Closed 11 months ago

UI glitch - clear recent history dialog does not shrink when collapsing details


(Core :: Widget, defect, P4)

17 Branch



Tracking Status
firefox18 - ---
firefox19 - ---
firefox20 - ---
firefox22 --- affected
firefox23 --- affected
firefox24 --- affected
firefox25 --- affected


(Reporter: alice0775, Unassigned)



(Keywords: regression, Whiteboard: tpi:+)


(1 file)

Build Identifier:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 ID:20121122030852

See .
The height of "clear recent history dialog" does not shrink when collapse listbox.

Steps to reproduce:
1. Open the Clear Recent History Dialog(Ctrl+Shift+Del)
2. Click the details expander button
3. Click it again to collapse the details

Actual results:
The height of the dialog does not shrink

Regression window(m-c)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120730135738
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120731055938

Regression window(m-i)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120730192943
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120730194637

In local build:
Last Good: de293780ba8a
First Bad: b8a0228a10fa
Regressed by:
	b8a0228a10fa	Neil Deakin — Bug 357725, support minimum and maximum size constraints on windows and popups, r=mats,jmathies,karlt,smichaud,sr=neil
OS: Windows 7 → All
Not critical enough to track for release, although we would take a low risk fix on branches.
Assignee: nobody → enndeakin
FWIW, it looks like the code that is supposed to shrink the dialog is line 238 here:

> 229   /**
> 230    * Hide the history items list.
> 231    */
> 232   hideItemList: function () {
> 233     var itemList = document.getElementById("itemList");
> 234     var expanderButton = document.getElementById("detailsExpander");
> 235 
> 236     if (!itemList.collapsed) {
> 237       expanderButton.className = "expander-down";
> 238       window.resizeBy(0, -itemList.boxObject.height);
> 239       itemList.setAttribute("collapsed", "true");
> 240     }

That resizeBy call is apparently having no effect.
howdy y'all,

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20100101 Firefox/22.0

the dialog DOES shrink. unfortunately, it shrinks only after the 1st cycle of the details button. that leaves the large-ish blank section from the earlier fail-to-shrink in place.

take care,
Happens on Mac Nightly Release 27a1, too.
Since this is still open 15 cycles after it was reported, I had a quick look at the code -- an idea: maybe the resize-down fails because you're not collapsing the list element first, and it's set to not resize smaller than the control sizes that fit in the dialog, somewhere?
If so, then simply collapsing BEFORE the size-down and expanding AFTER the size-up would fix it, I think.
Flags: needinfo?(dholbert)
I experimented a little and my idea in comment 15 didn't work.

Perhaps the issue here is that the prefpane element resizes automatically to fit the expanded listbox into it, which prevents the window from being sized down (since I don't think it automatically shrinks again). When expanded a second time, the extra space at the bottom won't be taken up by the auto-expanded prefpane and as such can be shrunk again? I'm not intimitely familiar with the inherent behavior of the different XUL controls, so maybe someone in-the-know can shed some light on that.
Flags: needinfo?(dholbert)
Assignee: enndeakin → nobody
Blocks: fx-qx
See Also: → 1200045
In experiment,

1. when remove `persist="collapsed"` from sanitize.xul, The UI wont expand longer any more. But the window still does not shrink after collapse

2. remove window.resizeBy statements in showItemList/hideItemList does not effect anything
This sounds a lot like bug 1247824, but in a different place.
Priority: -- → P4
Priority: P4 → P1
Whiteboard: tpi:+
Changing back to a P4, not sure why this got bumped up.
Priority: P1 → P4
Summary: UI glitch with clear recent history dialog → UI glitch - clear recent history dialog does not shrink when collapsing details
As the "Clear recent history" dialog has been converted to be in-content in bug 1036595, it would have been great to fix this UI bug with too.
Severity: normal → S3

The severity field for this bug is relatively low, S3. However, the bug has 16 duplicates.
:spohl, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(spohl.mozilla.bugs)

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Flags: needinfo?(spohl.mozilla.bugs)
Closed: 11 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.