814589 - Thunderbird's Menu button has vertical lines on it that seem out-of-place

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Hmmwhatsthisdo]

Attachment: The menu button, with the vertical lines.

After upgrading to TB17, I noticed the new menu button has little vertical lines on it. After checking it on my laptop (both the desktop and laptop run Windows), it became clear it wasn't a graphics card bug. I'm not sure if they're supposed to be there, but the really seem out-of-place. After looking at them for a while, I suppose they *kinda* look like the dividers in the menu bar, but they still seem fairly out-of-place. Perhaps someone should remove them in the next update?

Comment 1

[Richard Marti (:Paenglab)]

Also the Firefox button will change to this glyph, see: http://people.mozilla.com/~shorlander/files/australis-designSpecs/australis-designSpecs-windows7-mainWindow.html. Other OS and applications are also using this symbol for menus and this will help to faster recognize there is a menu behind this button.

I close this bug with WONTFIX because of the reasoning I wrote.

Feel free to reopen this bug if you think you have a better solution which also Firefox will use.

Comment 2

[Hmmwhatsthisdo]

Yes, I fully expected to see a menu Button like the one in the mock-up. however, this one includes vertical lines on it. Perhaps it's the viewing angle, but they are much harder to see in the picture attached than they are in my window. These vertical lines (the thin, almost invisible ones - not the 3 horizontal ones) seem entirely out of place. 

Since I believe Richard misunderstood the report, re-marking as UNRESOLVED and un-marking WONTFIX.

Comment 3

[Richard Marti (:Paenglab)]

Sorry, I misunderstood you. Yes this is correct, I see them too.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: patch

Mike, I take you for review as you have always a Win7 machine ready.

I checked all other graphics and it is only this one affected. I don't know how this could happen.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 684615 [details] [diff] [review]
patch

Confirmed that this fixes the issue.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 684615 [details] [diff] [review]
patch

[Approval Request Comment]
I'm asking for approval down to TB 17 in the hope this can land also on this channel to fix the visual glitch also there and the users haven't to wait until TB 24.
This patch should be riskless as it only exchanges the image.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e2ec99c4e48a
https://hg.mozilla.org/releases/comm-aurora/rev/9c171b6e699a
https://hg.mozilla.org/releases/comm-beta/rev/7425fe0b83b7
https://hg.mozilla.org/releases/comm-esr17/rev/f9e20e7722f3