Created attachment 684683 [details] Screenshot: confirm reload post request dialog I think these dialogs were implemented without reference to a visual design and could really benefit from another pass.
The one shown in the screenshot is shown if you try to refresh the page after submitting data in a form via a POST request. Try going to gmail.com, enter incorrect username and password, click sign in, wait for it to finish loading, then refresh. To test alert, confirm and prompt you can try a test page like this one http://ncthakur.itgo.com/js02.htm
The dialog should look like many of our common dialogs seen in: gaia / shared / style / confirm.css
Nominating for blocking-basecamp because this actually causes bug 817878 which is a functional bug. The alert/prompt/confirm dialogs in the browser were implemented before a visual design existed and could really do with another pass, but I guess it's a product call on whether this would block.
blocking-basecamp: --- → ?
Assignee: samuel → anthony
Are you happy to do this Anthony? If not I can do it.
Yeah, it's my only assigned bug for now so I'm happy to do it. :)
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
Created attachment 689729 [details] [diff] [review] Proposed patch
Attachment #689729 - Flags: review?(alive)
Comment on attachment 689729 [details] [diff] [review] Proposed patch r=me, good cleanup
Attachment #689729 - Flags: review?(alive) → review+
So new design done. Please open follow ups if it broke some stuff.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Verified as fixed on Unagi build 201231070201.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.