[Browser] Alert, confirm, prompt and confirm reload post request could do with some polish

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

Firefox OS
Gaia::Browser
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: benfrancis, Assigned: rik)

Tracking

({polish})

unspecified
B2G C3 (12dec-1jan)
polish
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: visual design UX-P2)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 684683 [details]
Screenshot: confirm reload post request dialog

I think these dialogs were implemented without reference to a visual design and could really benefit from another pass.
Assignee: nobody → padamczyk
Priority: -- → P2
The one shown in the screenshot is shown if you try to refresh the page after submitting data in a form via a POST request. Try going to gmail.com, enter incorrect username and password, click sign in, wait for it to finish loading, then refresh.

To test alert, confirm and prompt you can try a test page like this one http://ncthakur.itgo.com/js02.htm
Assignee: padamczyk → samuel
The dialog should look like many of our common dialogs seen in:
gaia / shared / style / confirm.css
Created attachment 686227 [details]
Confirm Dialog Examples
Whiteboard: visual design → visual design UX-P2
(Reporter)

Updated

5 years ago
Blocks: 817878
(Reporter)

Comment 4

5 years ago
Nominating for blocking-basecamp because this actually causes bug 817878 which is a functional bug.

The alert/prompt/confirm dialogs in the browser were implemented before a visual design existed and could really do with another pass, but I guess it's a product call on whether this would block.
blocking-basecamp: --- → ?
(Reporter)

Comment 5

5 years ago
Refactoring this could also fix bug 817882 which is blocking-basecamp+
Blocks: 817882
blocking-basecamp: ? → +
Assignee: samuel → anthony
(Reporter)

Comment 6

5 years ago
Are you happy to do this Anthony? If not I can do it.
(Assignee)

Comment 7

5 years ago
Yeah, it's my only assigned bug for now so I'm happy to do it. :)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED

Comment 8

5 years ago
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
(Assignee)

Comment 9

5 years ago
Created attachment 689729 [details] [diff] [review]
Proposed patch
Attachment #689729 - Flags: review?(alive)
Comment on attachment 689729 [details] [diff] [review]
Proposed patch

r=me, good cleanup
Attachment #689729 - Flags: review?(alive) → review+
(Assignee)

Comment 11

5 years ago
So new design done.

Please open follow ups if it broke some stuff.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 12

5 years ago
Verified as fixed on Unagi build 201231070201.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.