814681 - [Browser] Alert, confirm, prompt and confirm reload post request could do with some polish

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Ben Francis [:benfrancis]]

Attachment: Screenshot: confirm reload post request dialog

I think these dialogs were implemented without reference to a visual design and could really benefit from another pass.

Comment 1

[Patryk Adamczyk [:patryk] UX]

The one shown in the screenshot is shown if you try to refresh the page after submitting data in a form via a POST request. Try going to gmail.com, enter incorrect username and password, click sign in, wait for it to finish loading, then refresh.

To test alert, confirm and prompt you can try a test page like this one http://ncthakur.itgo.com/js02.htm

Comment 2

[Patryk Adamczyk [:patryk] UX]

The dialog should look like many of our common dialogs seen in:
gaia / shared / style / confirm.css

Comment 3

[Patryk Adamczyk [:patryk] UX]

Attachment: Confirm Dialog Examples

Comment 4

[Ben Francis [:benfrancis]]

Nominating for blocking-basecamp because this actually causes bug 817878 which is a functional bug.

The alert/prompt/confirm dialogs in the browser were implemented before a visual design existed and could really do with another pass, but I guess it's a product call on whether this would block.

Comment 5

[Ben Francis [:benfrancis]]

Refactoring this could also fix bug 817882 which is blocking-basecamp+

Comment 6

[Ben Francis [:benfrancis]]

Are you happy to do this Anthony? If not I can do it.

Comment 7

[Anthony Ricaud (:rik)]

Yeah, it's my only assigned bug for now so I'm happy to do it. :)

Comment 8

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 9

[Anthony Ricaud (:rik)]

Attachment: Proposed patch

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 689729 [details] [diff] [review]
Proposed patch

r=me, good cleanup

Comment 11

[Anthony Ricaud (:rik)]

So new design done.

Please open follow ups if it broke some stuff.

Comment 12

[Darren]

Verified as fixed on Unagi build 201231070201.