Closed Bug 814702 Opened 7 years ago Closed 7 years ago

toolkit/components/downloads/test/unit/test_privatebrowsing_cancel.js fails on Birch

Categories

(Toolkit :: Downloads API, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: ehsan, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is broken because the test assumes that the cancellation prompt will occur when entering private browsing mode and downloads are active. When per-window mode is enabled, the prompt only appears when exiting PB mode and downloads are active.
Cool.  Andres, it would be great if you guys can prioritize this.  Thanks!
Assignee: nobody → andres
Status: NEW → ASSIGNED
Depends on: 814701
Attached patch Patch v1Splinter Review
The test was migrated to a browser test and updated since now the logic is different with per-window PB. Previously, the test checked that when switching to PB in the same window, an alert was shown and the user had the change to cancel the download. Now, it only checks that is possible to cancel on a public window, but not in a private window. And that the actives downloads are correct according to the window. 

This test depends on Bug 814701, because introduces a head file also used in this test.
Attachment #685790 - Flags: review?(ehsan)
We also need to disable test_privatebrowsing_cancel.js (which I'll do when landing).
Attachment #685790 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/98edf6f6d9fe
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.