814738 - Modernize traversal of nsTObserverArrays

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

These classes explicitly iterate over nsTObserverArrays:
  nsAccessiblePivot (mObservers)
  nsEventListenerManager (mListeners)
  nsGlobalWindow (mIdleObservers)

As part of this, the ImplCycleCollectionTraverse for nsTObserverArray<T> needs to be converted to nsAutoTObserverArray<T, N>.

I have a patch floating around for this, mangled in with some other changes. I found these by renaming nsAutoTObserverArray::ElementAt to something else, then looking for compile errors.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: clean it up

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 684776 [details] [diff] [review]
clean it up

Make sure to push this to try.

Do we not need templates for nsTObserverArray? Only for the Auto* ?
Assuming this gets answered, r+

(I couldn't find cycle collected nsTObserverArrays, only Auto*)

Comment 3

[Andrew McCreight [:mccr8]]

Yeah, I did a Linux64 debug try run, and it was fine.

https://tbpl.mozilla.org/?tree=Try&rev=0f0e2dbb1b4e

I guess we just didn't have any nsTObserverArrays being CC-traversed. That would explain why a previous patch I had that broke the observe template for them still compiled.

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0e7e7d26f56

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0e7e7d26f56