814741 - WebRTC crash [@nr_ice_peer_ctx_parse_global_attributes]

Status: RESOLVED DUPLICATE of bug 817431

(Core :: WebRTC, defect, P2)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

Assertion failed: (strlen(str) == 0), function nr_ice_peer_ctx_parse_global_attributes, file /Users/cdiehl/Code/Mozilla/mc-inbound-asan/media/mtransport/third_party/nICEr/src/ice/ice_parser.c

Tested with m-i changeset: 113726:0c4a3db883da

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

This basically is asserting that we've correctly parsed the data in a global attribute received from the other side.  If the data for the option includes garbage (or no data is expected), when we end up assert()ing.

Probably the assert here should do what we do on various other parse failures and ABORT(R_BAD_DATA).  This also applies to a number of the other parse routines here, which also have the same sort of assert.  At least one had already had the change made.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: change asserts for extraneous data in ICE responses to failures

Comment 3

[Eric Rescorla (:ekr)]

Actually, in a number of cases these shouldn't even be errors, becuase the grammar allows extra data.
I had to change one of these to get interop with Google, who put extra stuff in the candidate lines.

So what we need to do is audit these for where extensions are allowed.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Assigned to ekr, but added Jan-Ivar; another bug he could delve into with some pointers at relevant specs.

Comment 5

[Eric Rescorla (:ekr)]

This is a dup of 817431