814781 - [BB][value_selector] - Value selector does not properly present items (truncated)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P3)

Description

[Casey Yee]

When selecting a contact with more than one email account, the value selector shows a list of emails associated with a contact.  The emails listed do not render correctly.

To reproduce:
1. Add multiple email accounts to a contact in contacts application.
2. Open email application and compose new email.
3. Tap "+" to add from contacts list.
4. Select contact in step 1.
5. Value selector does not properly present email addresses (truncated)
The entire line should also be selectable, not just the text (larger hit target)

Expected:
List of emails, perhaps also the name of the email as well:   
[Work] [e-mail]

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This seems like it is a contacts app problem and should be moved there?

Comment 2

[Josh Carpenter [:jcarpenter]]

Borja, does this sound more like a Contacts issue?

Gordon, does this sound like something we can tackle in the UX branch?

Comment 3

[ayman maat :maat]

Attachment: contact with multiple email addresses

Screenshot added to illustrate severity of problem

Comment 4

[ayman maat :maat]

RFI to josh to take this back into triage as the current implantation is unusable

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

After a talk with Casey Yee, he advise me to make this [BB] to support 'word-wrap'.
You can try to use a long email address (e.g. [e-mail]) and supports dir="rtl" too.

Comment 7

[Josh Carpenter [:jcarpenter]]

Sweet jeebus, that is busted. Reconfirmed in 1/7 build.

Triagers, I don't see how we can ship this. We should either fix or create a work around.

Comment 8

[Josh Carpenter [:jcarpenter]]

Removing "polish" keyword. This is broken functionality, and in no way a nice to have.

Comment 9

[Casey Yee]

Regarding Comment 6.
We may want to consider approaching the word-wrap issue in some other manner for a future release.  Its not a pretty fix but it will do the job for V1.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Since no one chimed in to say that this is not contacts, and it definitely is the contacts app, moving to the contacts app.

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: The bug!

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think this lives in Gaia System's value selector instead of Contacts app.

Dear Pavel,

May I know if you tried the case that the text in the option is very long and contains some spaces in it, which will be rendered as multiple lines originally.

BTW, I don't understand how you are going to do with this patch, is it doing to UX branch?
Since this is a bb+ issue, please let me know if I handle the rest for you including my first question.

Thank you.

Comment 13

[ayman maat :maat]

(In reply to Casey Yee [:cyee] from comment #9)
> Regarding Comment 6.
> We may want to consider approaching the word-wrap issue in some other manner
> for a future release.  Its not a pretty fix but it will do the job for V1.

I would strongly advise against wrapping text. its going to make it look messy and reduce readability. this should be our last resort. I would suggest reducing the font size as a first step.

RFI to Victoria (visual designer) to look into font size reduction.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 698856 [details]
patch

https://github.com/mozilla-b2g/gaia/commit/a755c1b33e871226a0f9f0acdbd435d7ae35f606

Comment 15

[Casey Yee]

Summarizing in-person conversation with Ayman:

We will accept the patch as is.   We will revisit the wrapping behavior post V1 where we would like to see more intelligent wrapping of the text.  Ideally we wrap at the "@" of an email address so that we maintain readability of the domain name and TLD.

Comment 16

[Josh Carpenter [:jcarpenter]]

Sounds good to me