814918 - FM is not turning off when enabling on airplane mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Michael Vines [:m1] [:evilmachines]]

Test Steps:
1. Play FM.
2. Turn on airplane mode.
3. FM continues in airplane mode.

Reproducibility: 100% reproducible.
In android and Windows phones, FM will stop when we turn on airplane mode. If we need the FM in airplane mode we need to go and explicitly enable FM again.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I'm working on this.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I'm almost finished but the system usually freezes while turning on/off radio.  The symptom seems like bug 812298.  Just note it here for reference.  I'll still try to work out and see if I can pass tests.
Although it is possible to turn off FM inside system app, if we need to restore playing FM after disabling airplane mode, writing codes inside FM apps may be a better choice.  (For situations like FM apps has already been unloaded, etc.)

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

My device continues hanging.  I've confirmed with Steven that bug 812298 represents the same problem encountered here.

Comment 4

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 5

[Dietrich Ayala (:dietrich)]

Does bug 812298 fix this entirely? Or is there additional work that needs to be done? 

That bug is waiting on the next kernel update.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Dietrich: Additional works needed, but the work in progress is almost done. I think I can land it in 1 or 2 days after bug 812298 fixed.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

Kernel update 4 released not long ago, and the problem of system freezing up is solved.  I confirmed that the patch works on the new kernel.
Tim, may you review my patch?

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 692821 [details]
Patch

r=me with nit addressed.

You should have this reviewed (but not landed) first, instead of waiting for the kernel update. Next time :)

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 692821 [details]
Patch

Thanks for notifying and reviewing!  Next time I'll make it reviewed first.
Changes above are updated and landed.  Closing this bug.

Comment 10

[John Shih]

verified on 2012-12-20-unagi
build info:
2012-12-18 unagi release build
gecko revision: "1527cf5192e32a1864dd47e38bfa8de7adf735ab"
gaia revision: "2b77f0a3fcc862c6925138d08fe44576da56bc7"