814986 - Social bottom toolbar breaks extension bottom-bars.

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[patrickjdempsey]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

Using AdBlock Plus's Open Blockable Items bottom-bar (Ctrl+Shift+V).  Drag bar to resize it larger and then smaller.


Actual results:

The web content remains in the upper position while the Blockable Items list shrinks.  I inspected the page and discovered the #pinnedchats element.  The following userChrome hack "fixed" this for me, but is obviously not a real solution:

#pinnedchats {display:none!important;}


Expected results:

Since I have social.enabled and social.active both set to false in about:config the #pinnedchat element should be hidden.  However that will leave the issue still broken when it is active.

Comment 1

[u279076]

I'm not seeing any issues in the latest Firefox Nightly with Adblock Plus 2.2.1. Can you please provide more details? Specifically, steps to reproduce and a screenshot of the issue would be of great use to me.

Comment 2

[patrickjdempsey]

As updates hadn't happened at the time of my posting, I was unable to test on other builds.  Now I can affirm this only happens on Firefox 17.  It's a shame it got released with this bug but I guess nothing can be done about it.

Comment 3

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

(In reply to patrickjdempsey from comment #2)
> Now I can affirm this only happens on Firefox 17.  It's a
> shame it got released with this bug but I guess nothing can be done about it.

That surprises me - the chatbar has a hidden attribute by default in 17 (see bug 809258) - so in theory it should only appear when social is enabled.

Comment 4

[patrickjdempsey]

According to that bug it landed during the merge on Beta 18.  A week late for 17.  I really wish Mozilla would do better testing of new new features that impact the main browser window before releasing them.  This was in fact actually reported in September here: https://bugzilla.mozilla.org/show_bug.cgi?id=794124 but ignored as extension error.

Comment 5

[Jonah Ho (AAstar)]

Reproducible on Beta and the latest Nightly.

Beta
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Build: 20130227063501

Nightly
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130302 Firefox/22.0
Build: 20130302030852

OS: Windows 7 x64

Steps to Reproduce:
1. Prerequisite: Have Adblock Plus 2.2.3 installed, and Facebook Messenger Social API turned on
2. Log into facebook and get into your News Feed
3. Press Ctrl-Shift-V to bring up Adblock's "Blockable items on current page" bar
4. Resize the bar by dragging up to increase size and then dragging down to decrease size.  If the bug does not appear at this point, drag all the way up until the bar takes up the entire Firefox window, and then quickly drag it all the way down.

Actual Results:
There is a section of grey screen produced that does not belong to the website nor to Adblock

Expected Results:
While the bar is being resized smaller (dragged down), the new space will be reclaimed by the website.

See screenshot for details.

Comment 6

[Jonah Ho (AAstar)]

Attachment: Bug Screenshot

Comment 7

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: Specify a max-height of 0px

Using the DOM inspector, I see that the chatbar is ending up with a height value that corresponds to the height of the gray area - so the resize is adjusting the height.  Replacing the "height: 0px" with "max-height: 0px" means I can no longer reproduce it.  There might be a better CSS trick to use which I'm not aware of though...

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 720497 [details] [diff] [review]
Specify a max-height of 0px

Review of attachment 720497 [details] [diff] [review]:
-----------------------------------------------------------------

perhaps we should have height & max-height as extra guarantee..

Comment 9

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

As suggested, I left the height value in place.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b10d28390d5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b10d28390d5

Comment 11

[u279076]

Patrick, can you please confirm this is fixed for you with the latest Firefox Nightly?