Closed Bug 815000 Opened 9 years ago Closed 9 years ago
Invalid calls to size
Social Panel To Content in error conditions cause console errors .
There are a few calls to sizeSocialPanelToContent which pass invalid params: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#363 http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#890 Both of the above are in the error handling code and only pass a single param when 2 are expected.
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #685915 - Flags: review?(felipc)
Comment on attachment 685915 [details] [diff] [review] Fix args Review of attachment 685915 [details] [diff] [review]: ----------------------------------------------------------------- thanks for catching this!
Attachment #685915 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2352627fb63 Gavin, This bug isn't too serious, but will mean that in error conditions, the toolbar and flyout panels will not be sized correctly and will cause an error to be written to the console. Should we uplift this anywhere?
(ESR10 is not affected, I'm pretty sure!) Yeah, given the simplicity of the fix, let's get this on beta/aurora.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment on attachment 685915 [details] [diff] [review] Fix args [Approval Request Comment] Bug caused by (feature/regressing bug #): 766616 User impact if declined: Panels with social error messages may be mis-sized. Testing completed (on m-c, etc.): Landed on m-c Risk to taking this patch (and alternatives if risky): Low risk - only impacts social in error conditions String or UUID changes made by this patch: None
Please remove [qa-] whiteboard tag and add verifyme keyword if there's some QA testing needed here. Otherwise we will skip verification.
Wontfixing for esr17 since this doesn't meet landing criteria there. Would reconsider if there was a lot of requests from the mailing list or in this bug saying this was a significant issue in ESR deployments.
You need to log in before you can comment on or make changes to this bug.