815007 - Remove test client code from inventory

Status: RESOLVED FIXED

(Infrastructure & Operations :: Infrastructure: Other, task)

Description

[Jacques Uber [:uberj]]

These patches resolve the issue in comment 1 in bug 800070. Patches can be found on https://github.com/uberj/mozilla_inventory/compare/remove_test_client_from_used_code. These are the commits I'm asking for review of: 

commit f8cd3e1693cf2feb98366ab299cec959bf37883b
Author: uberj <[e-mail]>

    Removed all calls using the test client from a Rack instance's __init__ method.
    Since add_all_dhcp_zones_to_schedulded_tasks.py is a script and builds it's own funfactory environment it will not have issues with middl

commit 854fc715ce51953054284f32c21d96d835cce4e7
Author: uberj <[e-mail]>

    Removed all use of the test client in dhcp views. I also fixed a small typo that was preventing the second dns server option from being d

commit 94f6373fab3021a91598517c00cf2bb9d6703553
Author: uberj <[e-mail]>

    Removed the DHCPHandler in api_v1 that was using the test client to call views. As far as
    I can tell all DHCP calls are handled by version 2 of the api. The test client calls in api_v2 were also removed.

commit d37ea4bea4322ee1949714c6329ae36a79be9581
Author: uberj <[e-mail]>

    Removed the DHCPHandler that was using the test client to call views. As far as
    I can tell all DHCP calls are handled by version 2 of the api.

commit 1b7b70adbd9abdd34c1315b315abea73bb267458

    replaced all test client calls with RequestFactory work around or by directy calling  other views.