815016 - [System] Click twice on FTU's finish button and you'll get a browser app opened, and the home button never works anymore.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

:evelyn told me her home button is not working anymore last week because my patch at Bug 812252,
So I do some investigation. Actually the cause is not patch of bug 812252.
Not sure if it's the same thing as Bug 814204.

STR:
1. Reset the phone by flashing a new firmware.
2. FTU shows.
3. As a developer I will click the next step buttons 'quickly', try to skip the config phase and training phase.

Expected:
Nothing happens and the FTU terminates normally.

Actual:
Browser app opens, and you cannot use the phone anymore unless you restart the phone because the home button is failed now.

Note:
The root cause is 
1. mozbrowserclose is fired twice, hence the window manager has a race condition in closing app.
2. z-index mess-up in commit https://github.com/mozilla-b2g/gaia/commit/aa6927c43424b4dda3fd93133390524cc4ff61c5
Because of 1., the window manager is still having some class regarding to FTU, so when FTU terminates, the homescreen actually is there on top of the lockscreen and the lockscreen is not available now because its z-index is lower than homescreen.
The user clicks the 'hidden' browser app icon, which causes the browser app opened.
And Because the lockscreen is still there, the home button is not working.

Beautiful combo!

Comment 2

[Borja Salguero [:borjasalguero]]

[:tchung] Could you try with tomorrow QA Build? Today we made a patch and I think that now it's working properly, but I would need your feedback. Thanks a lot!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

This still happens.

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: PR

Comment 5

[Borja Salguero [:borjasalguero]]

The fix was simpler than it looks... Simply we had to remove the listener in the 'let's go' button once we call window.close() ;). Ive moved all z-index styles to 'z-index.css' in order to make the CSS consistent.

Comment 6

[Borja Salguero [:borjasalguero]]

r+! Merged.

Comment 7

[sarsenyev]

 Reviewed and verified on "Unagi" device
 BuildID:20130103070201
 User able to skip FTU and the FTU terminates normally, by pressing "SKIP" or "NEXT"      button.