815067 - [Settings] Keyboard vibration - default value

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Walter Chen[:ypwalter][:wachen]]

This is a MozTrap test run Bug.

*Environment:
Phone - Unagi
Build: (2 different ones)
https://releases.mozilla.com/b2g/
2012-11-26 build
&
Master Gaia: 859fb6be47b5e644c6f24955071afe15b07b8192
Beta Gecko:  117123:cf5d5b6ddee8

*How to reproduce:
  1. Go to "Settings" app
  2. Go to "Keyboard"

*Expected Result: 
    "vibration" is selected.

*Actual Result:
    "vibration" is not selected.

Comment 1

[:Margaret Leibovic]

The default in settings.py is False:
https://github.com/mozilla-b2g/gaia/blob/master/build/settings.py#L60

However, even when I changed that to True, I still saw that we're getting false as the value when we're setting the checkbox's value in presetPanel:
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/settings.js#L140

I checked that the correct value made its way into settings.json. Maybe we're having problems reading that? I noticed a similar issue when looking into bug 815066.

Comment 2

[:Margaret Leibovic]

(In reply to Margaret Leibovic [:margaret] from comment #1)

> However, even when I changed that to True, I still saw that we're getting
> false as the value when we're setting the checkbox's value in presetPanel:
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/settings.
> js#L140
> 
> I checked that the correct value made its way into settings.json. Maybe
> we're having problems reading that? I noticed a similar issue when looking
> into bug 815066.

I think this is because |make install-gaia| wasn't updating the settings value in the profile on my device. When I used a new profile, the value was true, as expected.

Is there a way to update the default pref value such that it propagates to existing profiles?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Margaret, do you already have a patch?  I'm happy to r+ and we can land this.

(In reply to Margaret Leibovic [:margaret] from comment #2)
> Is there a way to update the default pref value such that it propagates to
> existing profiles?

Nope.  (Not without significant pain, anyway.)  Doesn't block this though.

Comment 5

[:Margaret Leibovic]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/6766

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 687314 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/6766

https://github.com/mozilla-b2g/gaia/commit/a082ecb011a1cc4952bc2cb84993716de3e69fa8

Comment 7

[Walter Chen[:ypwalter][:wachen]]

I verified it in 20121212 build http://releases.mozilla.com/b2g/