Closed Bug 815172 Opened 7 years ago Closed 7 years ago

Cleanup and remove changes from nsIBrowserDOMWindow for elm -> m-c migration

Categories

(Firefox for Metro Graveyard :: General, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

(Whiteboard: [metro-it1][LOE:1][metro-mvp])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
There was code added into nsIBrowserDOMWindow early on to get things to work for C++ code to call into javascript things.  Since then we've moved the appbar to JS so not everything is needed.  Also nsIBrowserDOMWindow isn't the right place for Metro specific functionality like this.
Attachment #685181 - Flags: review?(jmathies)
Comment on attachment 685181 [details] [diff] [review]
Patch v1

Review of attachment 685181 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/winrt/MetroContracts.cpp
@@ +305,5 @@
>  HRESULT
>  FrameworkView::OnDataShareRequested(IDataTransferManager* aDTM,
>                                      IDataRequestedEventArgs* aArg) 
>  {
> +  nsCOMPtr<nsIMetroUIUtils> metroUIUtils = do_CreateInstance("@mozilla.org/metro-ui-utils;1");

nit - check the result here before invoking metroUIUtils. same below.
Attachment #685181 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/projects/elm/rev/10db67c36550
Whiteboard: [metro-it1][LOE:1][metro-mvp] → [metro-it1][LOE:1][metro-mvp][completed-elm]
Had to back this out, not doing a clean build bit me. 
I think widget is built before browser so it doesn't find MetroUIUtils.h when doing a clean build.

I think maybe I'll have to move that js component inside widget?  Any other suggestion?  I'm not sure how else to access PanelUI for showing panels from C++ code.
Whiteboard: [metro-it1][LOE:1][metro-mvp][completed-elm] → [metro-it1][LOE:1][metro-mvp]
(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Had to back this out, not doing a clean build bit me. 
> I think widget is built before browser so it doesn't find MetroUIUtils.h
> when doing a clean build.
> 
> I think maybe I'll have to move that js component inside widget?  Any other
> suggestion?  I'm not sure how else to access PanelUI for showing panels from
> C++ code.

Can't think of any reason why a js module couldn't live in widget.
Attached patch Patch v1 - m-cSplinter Review
This request is for the bits that won't be merged in by the pending big elm merge.
Attachment #685181 - Attachment is obsolete: true
Attachment #685786 - Flags: review?(jmathies)
Comment on attachment 685786 [details] [diff] [review]
Patch v1 - m-c

awesome, thanks!
Attachment #685786 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/f5e2eba79e1b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.