815256 - Return the right app pref dirs in XPCShellDirProvider

Status: RESOLVED INVALID

(Core :: General, defect)

Comment 1

[Jim Mathies [:jimm]]

Attachment: wip

The app dir ini file fix solves a lot of problems, but we still need to update the app dirs the XPCShellDirProvider returns to tests.

Comment 2

[Jim Mathies [:jimm]]

Note the removed chunk

} else if (!strcmp(prop, NS_APP_PLUGINS_DIR_LIST)) {
..
}

on bottom left was duplicate code on elm due to a bad merge.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Jim Mathies [:jimm] from comment #2)
> Note the removed chunk
> 
> } else if (!strcmp(prop, NS_APP_PLUGINS_DIR_LIST)) {
> ..
> }
> 
> on bottom left was duplicate code on elm due to a bad merge.

I'd prefer a patch against m-c.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Mike Hommey [:glandium] from comment #3)
> (In reply to Jim Mathies [:jimm] from comment #2)
> > Note the removed chunk
> > 
> > } else if (!strcmp(prop, NS_APP_PLUGINS_DIR_LIST)) {
> > ..
> > }
> > 
> > on bottom left was duplicate code on elm due to a bad merge.
> 
> I'd prefer a patch against m-c.

ah, sorry, will update.

Comment 5

[Jim Mathies [:jimm]]

Attachment: patch v.1

Comment 6

[Jim Mathies [:jimm]]

Pushed to try:

https://tbpl.mozilla.org/?noignore=0&tree=Try&rev=3fa5415283da

Comment 7

[Jim Mathies [:jimm]]

No longer needed.