815260 - [SMS][BB] Apply lists BB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P3)

Comment 1

[Borja Salguero [:borjasalguero]]

We need the patch in order to apply 'getThreads' with building blocks. The patch is done and r+, and it's blocking other bb+ bug, so for being consistent we should update it to bb+

Comment 2

[Borja Salguero [:borjasalguero]]

[arnau]: Could you add the patch https://github.com/mozilla-b2g/gaia/pull/6636 as a atachment?  Thanks!

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

BB-, polish work

Comment 5

[Borja Salguero [:borjasalguero]]

Hi there. This one it's so important in order to make all changes about performance, and it's blocking all the changes coe ming in SMS App. The patch will be delivered in 5 min, so We would need to have BB+ if we want to accomplish the goals for V1.

Comment 6

[Borja Salguero [:borjasalguero]]

This is blocking a blocker, so for being consistent we need bb+ asap!

Comment 7

[Maria Angeles Oteo (:oteo)]

Appling BB was agreed to be nominated directly as BB+

Comment 8

[David Scravaglieri [:scravag]]

Part of a bigger issue

Comment 9

[Borja Salguero [:borjasalguero]]

Attachment: PR

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I don't understand why the list building blocks is needed to switch to a new DOM API. blocking-basecamp?

Comment 11

[Borja Salguero [:borjasalguero]]

It's blocking basecamp due to this is adding Building Blocks ;) (check with David)

Comment 12

[David Scravaglieri [:scravag]]

Borja, could you argument Comment 10 please ?

Comment 13

[Borja Salguero [:borjasalguero]]

There is no modification related with DOM API. This change is needed for fixing the following https://bugzilla.mozilla.org/show_bug.cgi?id=808819 , due to we need to use the latest Building Blocks related with List, and due to Threads&Messages are tied to this BB, we need to land this one first.

Once we have this Building Block applied (The path is available as an attachment), I will generate the new patch for applying our new&well-optimized method 'getThreadList'! ;)

Comment 14

[David Scravaglieri [:scravag]]

Blocks the 808819 which is a blocker.