815339 - [OS.File] Extract PromiseWorker from OS.File

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Not sure yet how to approach bug 801598, but we can already extract the part of OS.File that wraps communication with a worker in promises, and this will be useful for bug 753768.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Extracting PromiseWorker from OS.File

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 685324 [details] [diff] [review]
Extracting PromiseWorker from OS.File

Review of attachment 685324 [details] [diff] [review]:
-----------------------------------------------------------------

Even if we wind up doing something different, I think this is much cleaner.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b3522a6c08

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for bug 817923.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dcf727f6fba

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=0978e76cd86d

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: Extracting PromiseWorker from OS.File

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Unfortunately, this has bitrotted more than I'm comfortable fixing up myself. Please post a rebased patch.

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=031a41e36e24

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Attachment: Extracting PromiseWorker from OS.File, v2

Same one, minus bitrot.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52b5ac587767

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/52b5ac587767

Comment 13

[Eric Shepherd [:sheppy]]

Hey all -- doing some doc updating here. I see there's some documentation already created, and I'm updating and tidying that up, and I notice that it's importing PromiseWorker.js instead of PromiseWorker.jsm. Which are you supposed to use, or are both used but in different circumstances, or...?

Comment 14

[David Teller [:Yoric] - still alive but not very active]

PromiseWorker.js needs to be imported from the worker, while PromiseWorker.jsm needs to be imported from the main thread.