815532 - Bugzilla::User objects should be cached where appropriate

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[:glob ✱]

the object cache introduced in bug 811280 should be extended so user objects are also cached.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 685514 [details] [diff] [review]
patch v1

Review of attachment 685514 [details] [diff] [review]:
-----------------------------------------------------------------

Missing Bugzilla::Comment::author

Also I don't think it would be too difficult to add caching calls to the Bugzilla::Object::new_from_list method which would be a big help as well. new_from_list is used quite a bit for preloading and other places which means that if new_from_lists loads a set of users, and then later Bugzilla::User->new is called for the same user id then it is reloaded from the db.

Comment 3

[:glob ✱]

Comment on attachment 685514 [details] [diff] [review]
patch v1

(In reply to David Lawrence [:dkl] from comment #2)
> Also I don't think it would be too difficult to add caching calls to the
> Bugzilla::Object::new_from_list method which would be a big help as well.

agreed, but i'd like to address that in another bug.  i don't think it would be a simple change, as new_from_list doesn't call the normal object creation methods, so it's possible we'll hit problems where we cache objects which haven't been initialised fully.

filed as bug 819420, re-requested review.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 685514 [details] [diff] [review]
patch v1

Review of attachment 685514 [details] [diff] [review]:
-----------------------------------------------------------------

Be sure to add Bugzilla::Comment::author on commit. r=dkl

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Component.pm
modified Bugzilla/Flag.pm
Committed revision 8519.