Standardize the Bluetooth permissions name (bluetooth or mozBluetooth)

RESOLVED FIXED in Firefox 18

Status

()

Core
DOM: Device Interfaces
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: pauljt, Assigned: gwagner)

Tracking

unspecified
mozilla20
x86
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
The bluetooth code has the permissions "mozBluetooth" but the PermissionsInstaller.jsm has both bluetooth and mozBluetooth. 

"bluetooth" would be better imho since all other permissions and lowercase and unprefixed, but really I just need to know which is the "correct" one.
Nice catch! We're going to hook up the system message mechanism to the permission module and also confused about which one is actually preferred.

If we prefer "bluetooth" then we need to modify the permission check in BluetoothManager.cpp which is still using "mozBluetooth".

All the bluetooth-related apps seems supporting both "bluetooth" and "mozBluetooth".
Blocks: 805655
(In reply to Gene Lian [:gene] from comment #1)
> Nice catch! We're going to hook up the system message mechanism to the
> permission module and also confused about which one is actually preferred.
> 
> If we prefer "bluetooth" then we need to modify the permission check in
> BluetoothManager.cpp which is still using "mozBluetooth".
> 
> All the bluetooth-related apps seems supporting both "bluetooth" and
> "mozBluetooth".

I'm o.k with the change. For Bluetooth module, like Gene mentioned, only one line in BluetoothManager.cpp needs to be modified.
(Assignee)

Comment 3

5 years ago
The change is not hard but we have to be careful that we don't break anything. I made a couple of these changes already and the best thing to do is: add new permission to gaia, wait until it gets to all gaia branches, update the permission name in gecko, wait until we land the patch on all branches (including beta), remove old permission from gaia.
I think for bluetooth I already started landing the change on gaia a while back but I never finished landing the gecko change. So it's kind of my mistake that we have this mozBluetooth and bluetooth mess.
(Assignee)

Comment 4

5 years ago
Created attachment 685760 [details] [diff] [review]
patch

Lets change it. I checked the Gaia permissions and they all support mozBluetooth and bluetooth so we are good there.
Assignee: nobody → anygregor
(Assignee)

Updated

5 years ago
blocking-basecamp: --- → ?
(Assignee)

Updated

5 years ago
Attachment #685760 - Flags: review?(kyle)
Attachment #685760 - Flags: review?(kyle) → review+

Updated

5 years ago
blocking-basecamp: ? → +
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed22fe593f97
(Assignee)

Comment 6

5 years ago
Created attachment 685773 [details] [diff] [review]
Patch to remove mozBluetooth permission from permission table

This should land once we removed all the mozBluetooth permissions in Gaia.
Attachment #685773 - Flags: review?(kyle)
Attachment #685773 - Flags: review?(kyle) → review+
(Reporter)

Updated

5 years ago
Blocks: 814293
(Assignee)

Updated

5 years ago
Whiteboard: leave-open
(Assignee)

Comment 7

5 years ago
Created attachment 685919 [details] [review]
PR pointer
Attachment #685919 - Flags: review?(jonas)
(Assignee)

Comment 8

5 years ago
PR 6670 should only land after https://bug815572.bugzilla.mozilla.org/attachment.cgi?id=685760 is distributed to all trees.

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ed22fe593f97
Attachment #685919 - Flags: review?(jonas) → review+
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/dc011fa9cc86
https://hg.mozilla.org/releases/mozilla-beta/rev/6031db9484d0
Keywords: checkin-needed
Setting priority based on triage discussions.  Feel free to decrease priority if you disagree.
Priority: -- → P2
(Assignee)

Comment 12

5 years ago
https://github.com/mozilla-b2g/gaia/commit/0680d1cdc3a9f916fb418a893ccdf4880f136210
(Assignee)

Comment 13

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e8ee650b33c
Whiteboard: leave-open
https://hg.mozilla.org/mozilla-central/rev/6e8ee650b33c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
https://hg.mozilla.org/releases/mozilla-aurora/rev/607cb05af726
https://hg.mozilla.org/releases/mozilla-beta/rev/03ebd1bd6a34
status-firefox18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.