815580 - the contact list presented after contacts are imported from SIM does not reflect the contact list on the SIM

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[ayman maat :maat]

Attachment: New contact list on phone after import from SIM

the contact list presented after contacts are imported from SIM does not reflect the contact list on the SIM

*Goal*
import contacts from SIM when the contact list on the phone is empty

*actions*
1) unlock phone
2) select contact icon in tray
3) select settings icon
4) select import from SIM
5) contacts imported

*expected result*
New contact list on phone presented reflects existing contact list on SIM 
refer to attachment 01 [details] [diff] [review] - Existing contact List on SIM.jpg

*actual result*
New contact list on phone looks nothing like the contact list on the SIM and is quite disorientating / somewhat unusable for the end user
refer to attachment 02 [details] [diff] [review] - New contact List on phone.jpg

Comment 1

[ayman maat :maat]

Attachment: Existing contact List on SIM

sorry, missed the screen shot of existing contact list on SIM when submitting this bug

Comment 2

[Gabriele Svelto [:gsvelto]]

I'm experiencing the same problem, out of the ~60 contacts on my SIM only the last 9 I had added have been imported correctly. This is on the Otoro flashed with a build made from yesterday's repository clone.

Comment 3

[Josh Carpenter [:jcarpenter]]

Nominating for blocking:

* Implementation is broken
* User will encounter this in FTE, creating a negative first impression of the device
* SIM card functionality is particularly important for target market, where users commonly own multiple cards.

Comment 4

[Gregor Wagner [:gwagner]]

Can someone verify that the contacts are imported correctly with another (android) phone? I remember the days when exporting to sim produced such contacts on the sim card because of various limitations.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Ayman can you check with a regular android phone just in case? Thanks.

Comment 6

[ayman maat :maat]

(In reply to Vivien Nicolas (:vingtetun) from comment #5)
> Ayman can you check with a regular android phone just in case? Thanks.

hey vivien

i just imported contacts from the same SIM to an android phone. the presentation on the Android is the same as detailed in attachment 'New contact list on phone after import from SIM' ...except that there is no /1 appended to each contact entry.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to ayman maat :maat from comment #6)
> (In reply to Vivien Nicolas (:vingtetun) from comment #5)
> > Ayman can you check with a regular android phone just in case? Thanks.
> 
> hey vivien
> 
> i just imported contacts from the same SIM to an android phone. the
> presentation on the Android is the same as detailed in attachment 'New
> contact list on phone after import from SIM' ...except that there is no /1
> appended to each contact entry.

Thanks for trying. So there is still the ';' between first and last name? Maybe some SIM card has a 'formatting'...

Comment 8

[ayman maat :maat]

(In reply to Vivien Nicolas (:vingtetun) from comment #7)
> (In reply to ayman maat :maat from comment #6)
> > (In reply to Vivien Nicolas (:vingtetun) from comment #5)
> > > Ayman can you check with a regular android phone just in case? Thanks.
> > 
> > hey vivien
> > 
> > i just imported contacts from the same SIM to an android phone. the
> > presentation on the Android is the same as detailed in attachment 'New
> > contact list on phone after import from SIM' ...except that there is no /1
> > appended to each contact entry.
> 
> Thanks for trying. So there is still the ';' between first and last name?
> Maybe some SIM card has a 'formatting'...

Yes it had a ';' between first and last names. it seemed to be there instead of a <space> as as contacts were displayed as follows:

Ayman;Maat
Vivien;Nicolas

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Gregor, do you know if this should be part of the code in dom/contacts/ to be smart about that or do you think Gaia should handle it?

Comment 10

[Gregor Wagner [:gwagner]]

I don't think we should try to be smart on the gecko side here. 
We only import an alphanumeric field (Vivien;Nicolas) and a number.
We don't even have the concept of given or last name when we import. 
Interpreting the alphanumeric field is part of importing different standards and that's not v1.

So if we want to solve it right now then gaia is the right place.

Comment 11

[alberto.pastor]

So what would be the solution here? Where that "/1" comes from?
We are just saving what is inside the simContact.name:

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/utilities/import_sim_contacts.js#L57

IMHO, if that is not part of the name, that's an error while reading from the SIM, not before saving the new contact.

Vivien?

Comment 12

[Gregor Wagner [:gwagner]]

(In reply to Alberto Pastor from comment #11)
> So what would be the solution here? Where that "/1" comes from?
> We are just saving what is inside the simContact.name:

That depends on the phone that stores the number on the SIM card and I don't think there is a standard for it.
Yoshi correct me if I am wrong but the only standard out there is that we have an ID and the number. Different phones store different things in the ID field.
I think "/1" is a delimiter that this phone OS uses. I haven't seen it before.

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi ayman
Can you enable the ril debug to true and attach the log

in /system/b2g/defaults/pref/user.js 
pref("ril.debugging.enabled", false) ->  pref("ril.debugging.enabled", true)

or 
adb remount
adb pull /system/b2g/defaults/pref/user.js user.js
[update user.js with 'pref("ril.debugging.enabled", true);']
adb push user.js /system/b2g/defaults/pref/user.js
adb shell reboot

Comment 14

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 15

[ayman maat :maat]

note to self to attend to comment 13

Comment 16

[ayman maat :maat]

Attachment: Ayman Maat log cat traces 2012 12 07

as requested in comment 13

Let me know if you require any more information

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to ayman maat :maat from comment #16)
> Created attachment 689733 [details]
> Ayman Maat log cat traces 2012 12 07
> 
> as requested in comment 13
> 
> Let me know if you require any more information
Hi ayman
Thanks for providing the log,
but seems you didn't do 'Import SIM contact", right?

Comment 18

[ayman maat :maat]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #17)
> (In reply to ayman maat :maat from comment #16)
> > Created attachment 689733 [details]
> > Ayman Maat log cat traces 2012 12 07
> > 
> > as requested in comment 13
> > 
> > Let me know if you require any more information
> Hi ayman
> Thanks for providing the log,
> but seems you didn't do 'Import SIM contact", right?

hi yoshi.

yes i did. let me reset the phone back to 'factory settings' and import from SIM again. I will send you the log file when i have done this. Will upload it in around 4 hours (kids to deal with 1st).

Comment 19

[ayman maat :maat]

Hey Joshi.

I will email the log directly to you.

Comment 20

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to ayman maat :maat from comment #18)
> hi yoshi.
> 
> yes i did. let me reset the phone back to 'factory settings' and import from
> SIM again. I will send you the log file when i have done this. Will upload
> it in around 4 hours (kids to deal with 1st).

Maybe you can do 'make reset-gaia' in gaia directory.
I don't know if gaia has cached those SIM contacts but from the log you sent I didn't see any log related to import SIM contact.

Comment 21

[ayman maat :maat]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #20)
> (In reply to ayman maat :maat from comment #18)
> > hi yoshi.
> > 
> > yes i did. let me reset the phone back to 'factory settings' and import from
> > SIM again. I will send you the log file when i have done this. Will upload
> > it in around 4 hours (kids to deal with 1st).
> 
> Maybe you can do 'make reset-gaia' in gaia directory.

hey yoshi, sorry i cannot do  a 'make reset-gaia' in gaia directory as i do not have the repository cloned on my laptop

Comment 22

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ayman has sent me the log privately.

Currently I think the \1 and ; is from SIM

I attach one example here,

I/Gecko   (  110): RIL Worker: Parcel (size 148): 
0,0,0,0, // Solicited Response
75,0,0,0, // Token id
0,0,0,0, // Error 0 
144,0,0,0, // sw1 
0,0,0,0, // sw2
60,0,0,0, // String length
50,0,100,0, // 2d -
50,0,48,0, // 20 
52,0,51,0, // 43 C
54,0,56,0, // 68 h
55,0,50,0, // 72 r
54,0,57,0, //69 i
55,0,51,0, //73 s
55,0,52,0, //74 t
51,0,98,0, //3b ;
52,0,54,0, //46 F
54,0,97,0, // 6a j
54,0,102,0,// 6f o
55,0,50,0, // 72 r
54,0,52,0, // 64 d
50,0,102,0, //2f /
51,0,49,0, //31 1

So the name is "- Christ;Fjord/1" in this case.

Below are phone number, for privacy reason, some octets I use XX
48,0,XX,0
57,0,XX,0,
52,0,XX,0,
51,0,XX,0,
48,0,XX,0,
50,0,XX,0,
48,0,XX,0,
102,0,XX,0,

Below are trailing 0xff(means unused)
102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,0,0,0,0

Comment 23

[Gregor Wagner [:gwagner]]

Right, this is the actual entry on the SIM card. Even iphone has this problem.
If you look for the contacts-fixer-pro app you can read:
Fix Import From Sim: Fix issues occur when importing contacts from sim to the iPhone.
Example:
First name: Doe;John/1

Comment 24

[Dietrich Ayala (:dietrich)]

Who can fix this? Please assign yourself to the bug?

Comment 25

[alberto.pastor]

Is a bug, that even the iPhone has, a priority? Shouldn't we reconsider it?

Comment 26

[Julien Wajsberg [:julienw]]

If this is of any help, some non-smartphones (Sony-Ericsson are among them) are actually storing bizarly the contacts on the SIM.

/1 and /2 etc refer to the type of the phone for this contact (home, work, etc), and these non-smartphones are delimiting the first and last names with a semicolon. Since the length was limited, the name was not complete. Android seems to remove /1 /2 etc from the list, and it puts the phone number as "other", so it doesn't seem to use the information home/work/etc.

I had this problem when transitioning from a Sony-Ericsson to a Samsung (both non-smartphone) so I don't think we can do much.

There is a bug in Openmoko about this : http://docs.openmoko.org/trac/ticket/2085
It seems to have a lot more information than I have.

Either we implement this like OpenMoko or we resolve as invalid.

Comment 27

[Julien Wajsberg [:julienw]]

I can take this bug if we decide to implement it correctly, as I have some prior knowledge about this.

Comment 28

[Julien Wajsberg [:julienw]]

Vivien, what do you think of this ?

Comment 29

[Julien Wajsberg [:julienw]]

I've talked with Vivien and I'll try to implement this.

If this is not too much work I'll try to merge contacts if I can detect there are several phone numbers for one person.

Comment 30

[Gregor Wagner [:gwagner]]

Thanks Julien!
It's definitely nice to have but I don't think we should block on it.

Comment 31

[Daniel Coloma:dcoloma]

I agree with Gregor, we cannot be sure about how other devices store contacts in the SIM Card (they are not using any standard at all), even if we try to fix it, any change in the way they do it might make this effort useless.

Comment 32

[Julien Wajsberg [:julienw]]

I think this is mainly a thing of the past, and it seems there are at least 2 occurences (my phone, and maat's phone), so I think this is at least consistent, and we wouldn't try to do anything if we don't find this .*;.+\/\d regexp :)

But we'll do as the triagers say.

Comment 33

[David Scravaglieri [:scravag]]

Renominate if dogfooder impact is high.

Comment 34

[Julien Wajsberg [:julienw]]

Still not working.

Comment 35

[BMO Automation]

Firefox OS is not being worked on