815595 - Show carrier name according to SIM display conditions

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Current carrier name is got from network. But there are display conditions in SIM card might also decides the carrier name. There is a Gecko bug 793111 to expose display conditions to Gaia.

The longName/shortName will still be available. They stand for PLMN name. The displayed carrier name will be decided by PLMN name, SPN and display conditions. The display conditions change when PLMN changes. App which wants to show carrier name needs to listen to iccinfochange event for display condition change. The display conditions tell the app whether PLMN name or SPN should be a part of displayed name, but the app is allowed to concatenate the string in its own format.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Hi Patrick, is this a requirement you have recieved from somewhere? can you comment so the priority can be decided. thanks

Comment 2

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

Hi Joe,

This bug is actually the Gaia part of bug 793111. Bug 793111 is a basecamp-blocker, it is for displayed carrier name of MVNO. Currently, carrier name is the network name, which is received from the network. However, in MVNO environment, displaying carrier name requires some information from SIM.

Bug 793111 exposes the required information (SPN and display conditions, which are read from SIM) to Gaia, we will need some Gaia patch to make carrier name shown correctly. Thanks.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patrick, please update me on what need to be done on Monday offline... I am not sure I understand you fully in comment 0.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patrick has explained to me on the phone.

The new label update logic is:

iccinfo                     iccinfo                    
.isDisplayNetworkRequired   .isDisplaySpnRequired    Label to display
false                       false                    voice.network.shortName ||
                                                     voice.network.longName

true                        false                    voice.network.shortName ||
                                                     voice.network.longName

false                       true                     iccinfo.spn

true                        true                     (voice.network.shortName ||
                                                     voice.network.longName) +
                                                     ' ' + iccinfo.spn

beside voicechange and cardstatechange event, label display should also rely on iccinfochange event to update the label.

The patch is expected to touch lockscreen.js and statusbar.js.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/6812

https://github.com/mozilla-b2g/gaia/pull/6812

kk1fff, the only difference between this version and the one you tested is that I added a check to iccInfo.spn string -- if there is no string, isDisplaySpnRequired will be ignored.

Comment 6

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 688555 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/6812

Code looks good to me. I'm not very aware of carrier display name rules though.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/1a587d7c099618cabb439b87ab999a54f1272d0f

Comment 9

[Hubert Figuiere [:hub]]

It does not display the MVNO name in the Settings. Cellular & Data shows "Rogers Wireless". The status bar and the lockscreen are OK.

Comment 10

[sarsenyev]

Reviewed and verified on "Unagi"
Build ID:20130103070201
Carrier name matches with SIM display