815623 - "Not loading properly" appears very often

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P2)

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Many urls loaded from Evme end up with a "App is having problems".

Can be easily reproducible when clicking on the NY Times app.

1. On Evme, search for News.
2. Click on the black New York Times app (third row).
3. Immediately an error message appears.

Notice, the page loads from Gaia Firefox.

Comment 2

[Cristian Rodriguez (:crdlc)]

Hi Vivien, 

   I can reproduce the problem. It is strange because behind the overlay 'xxxx is not loading properly' I can see the web loaded :). Any idea?

Thanks

Comment 3

[Cristian Rodriguez (:crdlc)]

We receive a mozbrowsererror whose type is 'other' :) in window_manager

Comment 4

[Cristian Rodriguez (:crdlc)]

ok the problem is modal_dialog.js

Comment 5

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 685644 [details]
Patch v1

a=me.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/e865702a20684bce3bd1d2b81d248a36293f924f

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Backed out for causing numerous regressions 

https://github.com/mozilla-b2g/gaia/commit/2d31d72d00ce6db960e8cb87600b16074d8e66c3

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Patrick,
http://mobile.nytimes.com is fireing mozbrowsererror when first time loading. After reloading no error happens.
Could you help to distinguish what the exact error this is? Thank you.

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v2

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): regression of this bug
User impact if declined: several app don't load in wrapper
Testing completed: 
Risk to taking this patch (and alternatives if risky): IMHO with this patch no risk

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 686510 [details]
Patch v2

r=me, this is bb+ now.
Please keep in mind you should test your trivial patch which may cause non-trivial regression, from now on, every time. :)

Since this is a workaround, we should recover the error page in some day.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 686510 [details]
Patch v2

No need for approval since this blocks.

Comment 13

[Cristian Rodriguez (:crdlc)]

uppss sorry

Comment 14

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/115f0c4aa861cec845645c4c970f9bcc207bea5c

Comment 15

[mlevin]

Verified fixed on Unagi build 20130103070201. The NY Times page loaded properly.