815750 - [Twitter] Couldn't attach photo when composing a tweet

Status: RESOLVED DUPLICATE of bug 819617

(Web Compatibility :: Site Reports, defect, P3)

Description

[Zhenshuo Fang (:fang) - Firefox UX Team]

Composing a new tweet, Clicking on the camera icon and nothing happened.

[Expected] give the option of "take a photo" "choose from gallery" and "cancel"

Comment 2

[Jason Smith [:jsmith]]

Apparently I was wrong. This is supported functionality integrated directly into Gaia. In that case, most definitely a blocker and a regression.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

BB-. 3rd party application issue. Need Twitter to fix

Comment 4

[Jason Smith [:jsmith]]

(In reply to Joe Cheng from comment #3)
> BB-. 3rd party application issue. Need Twitter to fix

This isn't part of the twitter share functionality that was mentioned in the dupe?

Specifically:

https://github.com/mozilla-b2g/gaia/commit/1b3a322e9928a38295d59675bb41d338d99c7f52

Note - this is a preloaded app.

I want clarification around this.

Comment 5

[Jason Smith [:jsmith]]

Karen - Can you clarify? Do you know?

Comment 6

[Karen Ward [:kward]]

The version of the Twitter app that is currently in Marketplace is the "generic" version.  The version we intend to pre-install will have the functionality described above (attach photo).  Twitter has the code developed by TEF and is performing integration.  Expect to have the newer version of the app by Dec 10 or we will pre-install the generic version. (Adding Ron (BD owner, Donovan & Lisa to cc list)

Comment 7

[Jason Smith [:jsmith]]

Over to clee for a decision - v1 - generic version or newer version of the app? That will determine if this blocks or not.

Comment 8

[Peter Dolanjski [:pdol]]

Does this issue affect apps other than Twitter's generic version? 

Should the generic version work or are they doing something that is not standard? (I'm not familiar with standards around invoking camera/gallery)

Comment 9

[Daniel Coloma:dcoloma]

This is a 3rd Party App and the functionality will be offered by twitter. We do not need to block on this as FirefoxOS does not need any change, it is just the third party app the one that should be changed.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #9)
> This is a 3rd Party App and the functionality will be offered by twitter. We
> do not need to block on this as FirefoxOS does not need any change, it is
> just the third party app the one that should be changed.

I don't believe that's correct. See comment 6.

Comment 11

[Daniel Coloma:dcoloma]

(In reply to Jason Smith [:jsmith] from comment #10)
> (In reply to Daniel Coloma:dcoloma from comment #9)
> > This is a 3rd Party App and the functionality will be offered by twitter. We
> > do not need to block on this as FirefoxOS does not need any change, it is
> > just the third party app the one that should be changed.
> 
> I don't believe that's correct. See comment 6.

I don't see any contradiction between comment 10 and comment 6, could you please let me know what is incorrect?

To clarify: the twitter app is going to be developed by Twitter based on the code TEF created (we have shared that with them). This is a 3rd Party App, we do not need to block on that. 

The app that is available in e.me could be also changed by Twitter, it's up to them, and again a 3rd Party App.

Comment 12

[David Scravaglieri [:scravag]]

Chris, renominate if needed

Comment 13

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #11)
> (In reply to Jason Smith [:jsmith] from comment #10)
> > (In reply to Daniel Coloma:dcoloma from comment #9)
> > > This is a 3rd Party App and the functionality will be offered by twitter. We
> > > do not need to block on this as FirefoxOS does not need any change, it is
> > > just the third party app the one that should be changed.
> > 
> > I don't believe that's correct. See comment 6.
> 
> I don't see any contradiction between comment 10 and comment 6, could you
> please let me know what is incorrect?

Because it's a 3rd party preloaded app. We do block preloaded app issues that get us to the finalized grid.

> 
> To clarify: the twitter app is going to be developed by Twitter based on the
> code TEF created (we have shared that with them). This is a 3rd Party App,
> we do not need to block on that. 
> 

Disagree. 3rd party preloaded apps support is a v1 requirement, including the apps that have to be preloaded on device.

> The app that is available in e.me could be also changed by Twitter, it's up
> to them, and again a 3rd Party App.

We're not talking about everything.me here. If you look at the patch connected, you'll notice that this is directly part of the code base for doing exactly what this bug describes:

https://github.com/mozilla-b2g/gaia/tree/master/showcase_apps/twittershare

It's potentially a regression too given the feedback that showed up from test drivers.

renoming since this arguments have been given here clearly aren't paying attention to what's implemented. Please give me a more viable argument based on what's implemented. thanks.

Comment 14

[Peter Dolanjski [:pdol]]

We should block on preloaded apps not working properly as we can't ship with broken functionality (at least fundamental use cases like attaching a photo in a Tweet) in these apps.

Comment 15

[Daniel Coloma:dcoloma]

(In reply to Peter Dolanjski from comment #14)
> We should block on preloaded apps not working properly as we can't ship with
> broken functionality (at least fundamental use cases like attaching a photo
> in a Tweet) in these apps.

Where is that preloaded app available in github? I would like to check it.

Comment 16

[Daniel Coloma:dcoloma]

I would like to renominate his until:

1/ A clear steps to reproduce are available.
2/ The twitter app used for this 

By the way, the twittershare app pointed to in comment 13 is a showcase app, those apps (including crystalskull, cubevid...) are not intended to be included in production devices so if the bug is referred to that, should be bb-. 

Twitter will take that code and use it for another app not available yet as far as I know,

Comment 17

[Jason Smith [:jsmith]]

For [1] - the clear steps to reproduce are available. Naoki and myself were able to reproduce this no problem by the exact words in the title:

1. Sign into twitter into with an account
2. Start to compose a tweet
3. Select the camera option

Expected - Typically here a file chooser would appear allowing a user to select a photo from their device.

Actual - Nothing happens.

As for [2], the generic twitter app on marketplace I know definitely uses this (also known as the equivalent of m.twitter.com as viewed in the browser). That's true about the showcase app. However - I do note that we have been blocking typically on preloaded apps issues given that we're heavily judged by what we preload on the device. 

I'll unnom for now and send this over to tech evangelism since the mobile site is affected as well. If something changes where the generic version of the app gets preloaded, we may need to rethink about this.