815780 - [email] Manual setup process can infinitely stack 'setup-manual-config' and 'setup-progress' cards

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

'setup-progress' can push a 'setup-manual-config' card in the failure case where the user hits the manual setup button.
'setup-manual-config' will push a 'setup-progress' card once the user enters their details.

They don't pop each other, so they can stack forever.

In practice this is not a dangerous issue since correctness will be maintained and the user will get tired of re-entering data before we run out of resources.  But really if we already have a manual config card on the stack we should just pop the progress card rather than adding another one.  Or we can otherwise improve the UX flow.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

I am going to fix this as part of bug 816039.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

This is fixed with https://github.com/mozilla-b2g/gaia/pull/7027 from bug 809552.

This was addressed by having us transition back to the card that triggered the account creation attempt.  So when the user tries to create from manual config, they end right back up on the manual config page when the error happens.

Comment 5

[Mila Davydova]

Verified with Unagi, build ID 20130103070201

When the user tries to create an email account from manual configuration page, they end right back up on the manual configuration page when the error happens.