device_relay_info splits on ':' which breaks when server port is specified

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: jhopkins, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
device_relay_info (in mozpool/db/data.py) splits on ':' but doesn't take into account the host port number (if provided) such that:

 hostname=jhopkins-09135.local, bank=8080, relay=bank3:relay1

due to this code:

 > hostname, bank, relay = row[0].split(":", 2)

We may want to use a different separator or use some character escaping mechanism.
(Reporter)

Comment 1

6 years ago
Created attachment 685874 [details] [diff] [review]
use rsplit instead of split
Attachment #685874 - Flags: review?(dustin)
Attachment #685874 - Flags: review?(dustin) → review+
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.