Closed Bug 815898 Opened 9 years ago Closed 9 years ago

B2G build on macosx generates a bunch of sed errors (like bug 801418)

Categories

(Firefox OS Graveyard :: General, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Details

Attachments

(1 file)

> /Users/jlebar/code/moz/B2G/objdir-gecko/config/nsinstall -t -m 644 removed-files ../../dist/b2g
> cd ../../dist/b2g && find chrome -type f -name *.properties -exec sed -i '/^#/d' {} \;
> sed: 1: "chrome/en-US/locale/bra ...": command c expects \ followed by text
> sed: 1: "chrome/en-US/locale/en- ...": command c expects \ followed by text
> sed: 1: "chrome/en-US/locale/en- ...": command c expects \ followed by text
> [and so on]

I presume we need to port bug 801418 to b2g/installer/Makefile.in.
Attached patch Patch, v1Splinter Review
I have no idea what this does, but it seems to fix the problem.
Attachment #685909 - Flags: review?(mwu)
Assignee: nobody → justin.lebar+bug
Comment on attachment 685909 [details] [diff] [review]
Patch, v1

Looks like we're just copying the fix from bug 801418 , which is perfectly alright to me.
Attachment #685909 - Flags: review?(mwu) → review+
Does this error have any practical effect?  That is, do I need to backport this to branches?
(In reply to Justin Lebar [:jlebar] from comment #3)
> Does this error have any practical effect?  That is, do I need to backport
> this to branches?

It does exactly the same thing, in perl. We can port it if the branches aren't building on osx, I guess.
> We can port it if the branches aren't building on osx, I guess.

I mean, this error never kept me from successfully building.
Ah. In that case, no need to port. It just strips comments out of .properties files. Real builds are always on Linux anyway.
https://hg.mozilla.org/mozilla-central/rev/123b02c5b579
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.