815898 - B2G build on macosx generates a bunch of sed errors (like bug 801418)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

> /Users/jlebar/code/moz/B2G/objdir-gecko/config/nsinstall -t -m 644 removed-files ../../dist/b2g
> cd ../../dist/b2g && find chrome -type f -name *.properties -exec sed -i '/^#/d' {} \;
> sed: 1: "chrome/en-US/locale/bra ...": command c expects \ followed by text
> sed: 1: "chrome/en-US/locale/en- ...": command c expects \ followed by text
> sed: 1: "chrome/en-US/locale/en- ...": command c expects \ followed by text
> [and so on]

I presume we need to port bug 801418 to b2g/installer/Makefile.in.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

I have no idea what this does, but it seems to fix the problem.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 685909 [details] [diff] [review]
Patch, v1

Looks like we're just copying the fix from bug 801418 , which is perfectly alright to me.

Comment 3

[Justin Lebar (not reading bugmail)]

Does this error have any practical effect?  That is, do I need to backport this to branches?

Comment 4

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/123b02c5b579

Comment 5

[Michael Wu [:mwu]]

(In reply to Justin Lebar [:jlebar] from comment #3)
> Does this error have any practical effect?  That is, do I need to backport
> this to branches?

It does exactly the same thing, in perl. We can port it if the branches aren't building on osx, I guess.

Comment 6

[Justin Lebar (not reading bugmail)]

> We can port it if the branches aren't building on osx, I guess.

I mean, this error never kept me from successfully building.

Comment 7

[Michael Wu [:mwu]]

Ah. In that case, no need to port. It just strips comments out of .properties files. Real builds are always on Linux anyway.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/123b02c5b579