815968 - [Email App] Can't scroll down to view the full normal text email

Status: RESOLVED DUPLICATE of bug 813841

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Tony Chung [:tchung]]

on the 11/27 nightly build, i can't scroll down and view a normal text email in my gmail.   The only viewable region is what's on the screen now.

Smoketest blocker, i can't view my full email message.

no logcat fired at all when trying to pan.

Repro:
1) install 11-27-2012 unagi nightly build.  
* Version=18.0, BuildID=20121127071547
* gaia: 1087df834f985c4d01db455eb60163789499e086
* gecko: 04c2d4fc726f99facfabf85ebe6376996cac5dc8
2) launch email, set up a gmail account and go to inbox
3) find an email that's longer than the device viewport, in standard text format.  
4) pan down to read more of your text.   Verify you can't

Expected:
- pan up and down and read the full body of your text email

Actual;
- can't pan the email at all, it doesnt go past the viewport.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Are you sure it's a text e-mail?  What does "Show Original" (from the big down arrow to the right of the reply button) in gmail show for the "Content-Type:" header say?

Comment 2

[Tony Chung [:tchung]]

I did more testing, and it looks like html bodies do it too.   I also setup hotmail also, and same thing on certain mails... no scrolling allowed.   so its not just imap based.

how do i "show original" on a text based email?

Comment 3

[Tony Chung [:tchung]]

See a Screencast: http://youtu.be/LDxKEUBS10k

Comment 4

[Jim Porter (:squib)]

Tony, can you try this on a very short email that doesn't scroll (i.e. a line or two)? I was having a similar issue where messages were partly cut off, but I had chalked it up to a rendering bug on my machine, since I have some serious rendering issues right now on B2G desktop.

Comment 5

[Dylan Oliver [:doliver]]

blocking+ and P1 for smoketest blocker.

Comment 6

[Tony Chung [:tchung]]

Attachment: short clipped text screenshot

one liner.  its clipped.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

It's probably better to keep the HTML e-mails out of this; bug 813841 is about trying to improve their display and fix a quirks-mode related regression from making URLs interactive.

For "show original", when I said "in gmail" I meant using the gmail web interface.  Apologies for not being more clear.  This is important because plaintext e-mails are much less likely to glitch and break than any form of HTML email.

Comment 8

[Marcia Knous [:marcia]]

Here is the show original for the message I see clipped - looks as if the second line shows as text/html

MIME-Version: 1.0
Received: by 10.14.174.135 with HTTP; Wed, 28 Nov 2012 15:12:10 -0800 (PST)
Date: Wed, 28 Nov 2012 18:12:10 -0500
Delivered-To: [e-mail]
Message-ID: <CACKeFiyvVHyQX=q-6pgYNG9UqJjmZKBbE=[e-mail]>
Subject: Test
From: Marcia Knous <[e-mail]>
To: marcia <[e-mail]>
Content-Type: multipart/alternative; boundary=20cf302efb3ec4d32704cf964b2f

--20cf302efb3ec4d32704cf964b2f
Content-Type: text/plain; charset=ISO-8859-1

test

--20cf302efb3ec4d32704cf964b2f
Content-Type: text/html; charset=ISO-8859-1

test

--20cf302efb3ec4d32704cf964b2f--

Comment 9

[Dylan Oliver [:doliver]]

Jim, can you take this one?

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Marcia Knous [:marcia] from comment #8)
> Here is the show original for the message I see clipped - looks as if the
> second line shows as text/html

Yes, we will favor the text/html part in multipart/alternative.  So then this is probably actually bug 813841 which deals with HTML message display and scrolling.  The root cause relates to the sub-iframes stealing the scrolling events so the outer scroll region is unable to scroll.

That bug is not yet marked blocking, so I'm not going to dupe to it, but this bug is really a dupe of that bug.

Comment 11

[Jim Porter (:squib)]

(In reply to Andrew Sutherland (:asuth) from comment #10)
> That bug is not yet marked blocking, so I'm not going to dupe to it, but
> this bug is really a dupe of that bug.

I'm seeing a different bug here, then. The issue in comment 6 is a bug in HTML messages that occurs because we size the iframe to the scrollHeight of the body, but scrollHeight excludes height from margins. To fix that, we can either grab the height from the documentElement, which appears to give me a minimum of 150px for some reason, or we can use getComputedStyle to grab the top and bottom margins.

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

Right, we regressed by switching from non-quirk-mode to quirks-mode which reversed whether body or documentElement was the right thing to do.  We are fixing that in bug 813841.

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

Got to/from mixed up there.  We used to operate in quirks mode.  We changed that with the landing of URL linkification.  We no longer operate in quirks mode which regressed us, and the fix is forthcoming.  Please chime in on https://github.com/mozilla-b2g/gaia/pull/6676 if there is more we should do.

Comment 14

[Jim Porter (:squib)]

Based on my reading of the patch and the patch I was working on, that looks good.

Comment 15

[Dylan Oliver [:doliver]]

So are we clear to resolve this as a dup of 813841 then?

Comment 16

[Andrew Sutherland [:asuth] (he/him)]

Yeah, that got marked blocking and Jim agrees, so duping.