815973 - SocialErrorListener also catches errors from XHR

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Mark astutely pointed out that the SocialErrorListeners (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#1040) that are attached to the content panels also captures errors from XHR done by those pages, a case where the page itself is usually responsible for handling the error conditions.

Should these listeners ignore those errors? what about non-toplevel load errors (like iframes inside the page loading a 404)?

(On the other hand this overeager listener helped find bug 815053)

Comment 1

[Thomas Wisniewski]

Felipe, is this bug still valid, or is it obsolete after the recent overhaul of the Social API?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Let me redirect this to Shane since I don't know if this code still exist or if it was removed in the recent overhaul

Comment 3

[Shane Caraveo (:mixedpuppy)]

The error listener still exists in social-content.js, it is only used in the share panel now.  I'm not certain it is as over eager as it used to be.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Actually, haven't seen a problem from this in ages, closing it.