Closed Bug 815973 Opened 7 years ago Closed 3 years ago
Error Listener also catches errors from XHR
Mark astutely pointed out that the SocialErrorListeners (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#1040) that are attached to the content panels also captures errors from XHR done by those pages, a case where the page itself is usually responsible for handling the error conditions. Should these listeners ignore those errors? what about non-toplevel load errors (like iframes inside the page loading a 404)? (On the other hand this overeager listener helped find bug 815053)
Felipe, is this bug still valid, or is it obsolete after the recent overhaul of the Social API?
Let me redirect this to Shane since I don't know if this code still exist or if it was removed in the recent overhaul
Flags: needinfo?(felipc) → needinfo?(mixedpuppy)
The error listener still exists in social-content.js, it is only used in the share panel now. I'm not certain it is as over eager as it used to be.
Actually, haven't seen a problem from this in ages, closing it.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.