81601 - Left over files from 6.0/6.01 after updating to current build

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

Here is a list of left over files from 6.0/6.01 after updating to current build 
(both using the native installers).  I've cc:ed international folks because 
there are lots of language packs left over.  We need to see if they need to be 
deleted upon an upgrade, or if they will work just fine.

We need to figure out what files will/might cause problems after the upgrade.

===============================================================================
Comparing Netscape 6 (daily build)
       to Netscape 6.01
  chrome\
    CVS.jar...not in Netscape 6\chrome\
    en-DE.jar...not in Netscape 6\chrome\
    en-FR.jar...not in Netscape 6\chrome\
    en-GB.jar...not in Netscape 6\chrome\
    en-JP.jar...not in Netscape 6\chrome\
  components\
    gkhtml.dll...not in Netscape 6\components\
    mozucth.dll...not in Netscape 6\components\
    Netscape\
      Netscape6.01\...not in Netscape 6\components\Netscape\
    signed.dll...not in Netscape 6\components\
  defaults\
    isp\
      en-DE\...not in Netscape 6\defaults\isp\
      en-FR\...not in Netscape 6\defaults\isp\
      en-GB\...not in Netscape 6\defaults\isp\
      en-JP\...not in Netscape 6\defaults\isp\
      en-US\...not in Netscape 6\defaults\isp\
      US\
    messenger\
      en-DE\...not in Netscape 6\defaults\messenger\
      en-FR\...not in Netscape 6\defaults\messenger\
      en-GB\...not in Netscape 6\defaults\messenger\
      en-JP\...not in Netscape 6\defaults\messenger\
      en-US\...not in Netscape 6\defaults\messenger\
      US\
    pref\
      psm-glue.js...not in Netscape 6\defaults\pref\
    profile\
      en-DE\...not in Netscape 6\defaults\profile\
      en-FR\...not in Netscape 6\defaults\profile\
      en-GB\...not in Netscape 6\defaults\profile\
      en-JP\...not in Netscape 6\defaults\profile\
      en-US\...not in Netscape 6\defaults\profile\
      US\
        chrome\
    wallet\
      URLFieldSchema.tbl...not in Netscape 6\defaults\wallet\
  jsdom.dll...not in Netscape 6
  oji.dll...not in Netscape 6
  searchplugins\
    ClassifiedPlus.gif...not in Netscape 6\searchplugins\
    ClassifiedPlus.src...not in Netscape 6\searchplugins\
    Fresheye_Japan.gif...not in Netscape 6\searchplugins\
    Fresheye_Japan.src...not in Netscape 6\searchplugins\
    Netscape_France.gif...not in Netscape 6\searchplugins\
    Netscape_France.src...not in Netscape 6\searchplugins\
    Netscape_Germany.gif...not in Netscape 6\searchplugins\
    Netscape_Germany.src...not in Netscape 6\searchplugins\
    Netscape_Japan.gif...not in Netscape 6\searchplugins\
    Netscape_Japan.src...not in Netscape 6\searchplugins\
    Netscape_UK.gif...not in Netscape 6\searchplugins\
    Netscape_UK.src...not in Netscape 6\searchplugins\
    Nomade_FR.gif...not in Netscape 6\searchplugins\
    Nomade_FR.src...not in Netscape 6\searchplugins\
    SBMus_01.gif...not in Netscape 6\searchplugins\
    SBMus_01.src...not in Netscape 6\searchplugins\
    SBWeb_01.gif...not in Netscape 6\searchplugins\
    SBWeb_01.src...not in Netscape 6\searchplugins\
    SBWeb_02.gif...not in Netscape 6\searchplugins\
    SBWeb_02.src...not in Netscape 6\searchplugins\
    SBWeb_03.gif...not in Netscape 6\searchplugins\
    SBWeb_03.src...not in Netscape 6\searchplugins\
    SBWeb_04.gif...not in Netscape 6\searchplugins\
    SBWeb_04.src...not in Netscape 6\searchplugins\
    SBWeb_05.gif...not in Netscape 6\searchplugins\
    SBWeb_05.src...not in Netscape 6\searchplugins\
    SBWeb_06.gif...not in Netscape 6\searchplugins\
    SBWeb_06.src...not in Netscape 6\searchplugins\
    SBWeb_07.gif...not in Netscape 6\searchplugins\
    SBWeb_07.src...not in Netscape 6\searchplugins\
    Shareware.gif...not in Netscape 6\searchplugins\
    Shareware.src...not in Netscape 6\searchplugins\
    ShopNetscape.gif...not in Netscape 6\searchplugins\
    ShopNetscape.src...not in Netscape 6\searchplugins\
    UKPlus.gif...not in Netscape 6\searchplugins\
    UKPlus.src...not in Netscape 6\searchplugins\
    Voila_France.gif...not in Netscape 6\searchplugins\
    Voila_France.src...not in Netscape 6\searchplugins\
    WEB_DE.gif...not in Netscape 6\searchplugins\
    WEB_DE.src...not in Netscape 6\searchplugins\

Comment 1

[Daniel Veditz [:dveditz]]

Don't worry about the languages -- if the user tries to switch to them they 
won't work due to chrome versioning, and we don't necessarily know which ones 
the user has to try to delete.

What the heck is CVS.jar ?

Nuke the actual components (my list contains psmglue.dll in addition to the 
ones you listed). Feel free to leave the talkback subdirectories 
components/netscape/netscape6[.01]

Under defaults leave the regional directories, but nuke psm-glue.js and the 
wallet file. Leave the searchplugins.

At the top level you can nuke jsdom.dll. I don't know why oji.dll shows up on 
your list -- need it for pluggable Java to work. Kill psm.exe, though, and the 
psmdata directory (we'll get to find out if recursive rmdir works).

Comment 2

[Sean Su]

reassigning to myself

Comment 3

[Grace Bush]

changing QA

Comment 4

[Syd Logan]

Would be nice to know if there are any negative consequences to deferring this 
to post RTM. So far, this seems like a non RTM issue (in deference to crashers 
and such, we have to be careful what we chose given time and people constraints)

Comment 5

[Sean Su]

These files need to be removed upon installation:
  ...\components\gkhtml.dll
  ...\components\mozucth.dll
  oji.dll  (not sure if this is ours)
  ...\components\signed.dll

If not, then bug 71010 will show up

Comment 6

[Sean Su]

setting target milestone to --- for reconsideration for nsbeta1

Comment 7

[Jimmy Lee]

I agree with Sean.  I am opposed to mozilla0.9.3 as the milestone.  This issue 
affects Mac and Linux as well (Bug 81515 and Bug 81523, respectively)

This problem impacts website as well (Ccing Julie).  If a user can update from 
6.0/6.01 to a newer release from SmartUpdate, then these left over files still 
need to be dealt with.

Comment 8

[lchiang]

Bug 71010 is pretty bad where the user gets an error on startup about entry
point and missing files caused by leftover files.

Sean - mark 0.9.1 so this shows back up on radar.  Thanks.

Comment 9

[Sean Su]

setting target milestone to 0.9.1

Comment 10

[Sean Su]

let's try that 0.9.1 setting again.

Comment 11

[Sean Su]

Attachment: patch #1 (ns tree)

Comment 12

[Sean Su]

Attachment: patch #1 (moz tree)

Comment 13

[Phil Peterson]

PDT triage: for 0.9.1 we only need to fix enough of this bug to fix the "unknown
entry point" problem. We can do the full cleanup later (bug 71010?)

Comment 14

[Sean Su]

Attachment: patch #2 (ns tree)

Comment 15

[Sean Su]

Attachment: patch #2 (moz tree)

Comment 16

[Sean Su]

patches #2 will only delete:
  .../components/gkhtml.dll
  .../components/mozucth.dll

seeking r=,sr=

Comment 17

[Samir Gehani]

Second round of patches look good: but why are we uncommenting most of the list
only after beta1?  For risk redutcion?  If the latter is the case r=sgehani.

Comment 18

[Sean Su]

PDT want just enough to fix bug 71010.  So i decided to leave the code to delete  
the rest of the files commented out so it'll be a simple change after the beta.

Comment 19

[Scott MacGregor]

sr=mscott

Comment 20

[Sean Su]

just checked in patches #2.  however, I'm leaving this bug open because not all 
files have been taken care of.  I will comment on bug 71010 that it has been 
fixed.

Comment 21

[Sean Su]

hmm.. I should change the target milestone to 0.9.2 since I've fixed the 
problems for 0.9.1

Comment 22

[scottputterman]

I think we should remove signed.dll as well.  See
http://bugzilla.mozilla.org/show_bug.cgi?id=82219 for the reasons.  It looks
like the existence of this .dll is causign a crash.  Putting back on 0.9.1 radar

Comment 23

[Sean Su]

PDT: why are we not deleting all the oboslete files?  I thought QA was testing 
daily builds from clean dirs, which makes me think that there has been more 
testing done with builds on new dirs than with installing ontop of 6.0 or 6.01.

Comment 24

[Jimmy Lee]

Ccing Jeremy.

Comment 25

[(not reading, please use [e-mail] instead)]

don't we also have to worry about linux and mac?

Comment 26

[Jimmy Lee]

I made the comment yesterday, but I'll paste it here again.

"I agree with Sean.  I am opposed to mozilla0.9.3 as the milestone.  This issue 
affects Mac and Linux as well (Bug 81515 and Bug 81523, respectively)

This problem impacts website as well (Ccing Julie).  If a user can update from 
6.0/6.01 to a newer release from SmartUpdate, then these left over files still 
need to be dealt with."

Comment 27

[Sean Su]

Cc:ing [e-mail] since the other similar mac and linux bugs are assigned 
to him.

Comment 28

[Sean Su]

Attachment: patch #3 (ns tree) - this will delete all obsolete files

Comment 29

[Sean Su]

Attachment: patch #3 (moz tree) - this will delete all obsolete files

Comment 30

[Brendan Eich [:brendan]]

pdt wants every stinkin' file killed.
keilll all de files mon...  ;-)

chris h.

Comment 31

[selmer (gone)]

(and sorry for the wrong call on complete cleanup)

Comment 32

[Samir Gehani]

r=sgehani on {moz,ns} patch #3 

(NOTE: Deleting the component.reg file is still a problem due to our
post-install replace utility strategy but that's an orthogonal issue Don is
working on).

Comment 33

[Scott MacGregor]

sr=mscott

Comment 34

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 35

[Sean Su]

fixed.

Comment 36

[Grace Bush]

verified with 2001052808 build