816067 - [FTU. UX VD] Change background.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P3)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: GRey background pattern with noise texture

Change background for the repeated pattern used in settings for the light backgrpund and the following attachment for the dark grey one.

Comment 1

[Fernando Campo (:fcampo)]

Is this for settings or FTU? the description is not clear to me

Comment 2

[Victoria Gerchinhoren [:vicky]]

Settings and FTU should share the same background style in the light grey screens. The dark grey ones use the pattern attached.

Comment 3

[Fernando Campo (:fcampo)]

Patch on https://github.com/gordonbrander/gaia/pull/109

Comment 4

[Sam Joch [:samjoch]]

Review available on github: https://github.com/gordonbrander/gaia/pull/109/files

Comment 5

[Sam Joch [:samjoch]]

landed in uxbranch: https://github.com/gordonbrander/gaia/commit/f419e88c12412fd31087375d0d90b30a4deba95a

Comment 6

[Maria Angeles Oteo (:oteo)]

Hi Fernando or Sam, can you land the patch in master? 

As there is no clear answers about the UX branch purpose right now, it'd be better to land it in master so after that, we can ask for uplifting the patch to v1-train. Otherwise I am afraid the work done will be lost and it will not land in time or never in the commercial release v1.1.

Comment 7

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia   ace1eb32a313da1232bbdf9cff2581a4b036356d
BuildID 20130326070204
Version 18.0
Unagi

Comment 9

[Fernando Campo (:fcampo)]

Naoki, I just checked on v1-train branch, and the patch is not landed there.

Maybe you verified it on master?

Comment 10

[Fernando Campo (:fcampo)]

Attachment: Link to commit https://github.com/fcampo/gaia/commit/062ff84ecc94ad424a6ca22e868aa7029f3b2b27

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): obsolete background images
User impact if declined: visual 
Testing completed: 
Risk to taking this patch (and alternatives if risky): low, just UX changes
String or UUID changes made by this patch:

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

My mistake.  You are right, the actual fix is not in the v1 train, it is in the master:
https://github.com/mozilla-b2g/gaia/tree/v1-train/apps/communications/ftu/css/images
https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/ftu/css/images

Background looks darker for the FTE setup portion; I'm not sure if this is intentional?

Background change can be seen by the tutorial in master, which is not on v1 train.  Thanks.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 730094 [details]
Link to commit https://github.com/fcampo/gaia/commit/062ff84ecc94ad424a6ca22e868aa7029f3b2b27

low risk UX fix, we'll take the uplift to v1-train here.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 25d9e53380db967d76223c5f1e1940ed907ed447
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 14

[Julien Wajsberg [:julienw]]

v1-train: 1c38c91bb16f2bf0d5066c4787d2249463f61bb3

(I took 79a2c377340e294cb89b74e9b18cfe46f41d54e5 as master hash)

Comment 15

[Fernando Campo (:fcampo)]

Thanks Johnand and Julien :)

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/1d4c7fe3256e
Gaia   2f64311e0f23b85c29b20be9502cbdeaee8342ae
BuildID 20130405070205
Version 18.0
Unagi