816080 - May 15-16 Upgrade Bedrock to latest Playdoh

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect, P2)

Description

[Anthony Ricaud (:rik)]

We're way behind.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/dc6e5a6c817888b0fdcfea53ca178e6519f5838f
jingo.render is deprecated in recent versions of jingo

bug 816080

Comment 2

[Anthony Ricaud (:rik)]

I won't have the time to fix this so unassigning.

Comment 3

[Hector Zhao [:hectorz]]

I'd like to do this.

Comment 5

[Dan Poirier [:dpoirier]]

This looks like a dupe of 775529

Comment 7

[Paul [:pmac] McLanahan]

I'd argue for a higher priority since we're now on an unsupported release of Django.

Comment 8

[Andrei Hajdukewycz [:sancus]]

https://github.com/mozilla/bedrock/pull/558/ is the pull request. This pull request looks like a complete mess of merge commits to me. I was talking to Hector on IRC and the reason it is this way is because the first commit is a merge from playdoh/master and he wasn't sure about rebasing on a merge. I don't know if this is the right way to upgrade (http://playdoh.readthedocs.org/en/latest/getting-started/upgrading.html seems to suggest that if you aren't a relatively recent fork, you need to do it manually) but if it is, it seems like a squashed merge from playdoh/master and then individual fixes applied on top of that would be least disruptive of the history...

:pmac, :mkelly, What do you guys think?

Comment 9

[Andrei Hajdukewycz [:sancus]]

some more IRCing concludes: <pmac> we just need to reorganize our stuff and update vendor

Comment 10

[Hector Zhao [:hectorz]]

FYI, new PR is https://github.com/mozilla/bedrock/pull/755

Comment 11

[Paul [:pmac] McLanahan]

I saw that. I've been looking at it. Great work! I just want to test it out a lot and we'll probably push it to a demo server soon to hammer on it.

We'll also have to try to manage other PRs, but we can only do so much. This will be great. Thanks again!

Comment 12

[Mike Alexis [:malexis]]

We're blocking off May 15 and 16 to review and implement the playdoh upgrade. 

Wep ops will help test but there are no dependencies on their end.

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/8f7dabd14a95faddbecabc02e02c035c74da2b4b
Bug 816080: Upgrade Bedrock to latest Playdoh

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/807be421d6cbe6715a77aded7643d9db132bcfe5
Bug 816080: Revert rename of wsgi file to ease deployment pain.

Comment 15

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1ddb27692ee66063558f2ad206b8a6b9f3a0189f
Bug 816080: Add a dummy db and cache config for easy setup and deploy.

Django 1.4+ requires a db setting to run at all.

Comment 16

[Anthony Ricaud (:rik)]

Is this done then? Can we close?

Comment 17

[raymond [:retornam] (inactive)]

This is done and this bug can be closed