Closed Bug 816103 Opened 12 years ago Closed 12 years ago

Update webapps tests

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(3 files, 1 obsolete file)

      No description provided.
I got exceptions without this patch at some point
Attachment #686119 - Flags: review?(jhammel)
Attachment #686120 - Flags: review?(bzbarsky)
Comment on attachment 686120 [details] [diff] [review]
Part b (1): Update

r=me, though I mostly skimmed the tests.
Attachment #686120 - Flags: review?(bzbarsky) → review+
Comment on attachment 686119 [details] [diff] [review]
Part a: use bytestrings in parseFailures.py

This is no good.
Attachment #686119 - Flags: review?(jhammel)
So I tested this time and this works for both Python 3.2.2 and Python 2.7.2+ as installed here. Unless I'm much more stupid than I think, this version should be good enough.
Attachment #686119 - Attachment is obsolete: true
Attachment #686169 - Flags: review?(jhammel)
Nothing really interesting here; just looking for rs.
Attachment #686170 - Flags: review?(bzbarsky)
Attachment #686120 - Attachment description: Part b: Update → Part b (1): Update
Comment on attachment 686170 [details] [diff] [review]
Part b (2): Failures

r=me.  Please land this so I can remove some of these JSON bits.  ;)
Attachment #686170 - Flags: review?(bzbarsky) → review+
Comment on attachment 686169 [details] [diff] [review]
Part a: Handle encodings explicitly in parseFailures.py

wfm; stricly speaking the file operations should use `with file(...) as` but this is no change from the status quo (likewise, open(os.path.join(k, 'Makefile.in'), 'wb'))

Just out of curiousity, did you add the 'b' bits for a reason or just in case?"
Attachment #686169 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/1e998904dbf4
https://hg.mozilla.org/mozilla-central/rev/92137d55d9f3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Depends on: 820867
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: