816122 - [traceback] MaxRetriesExceededError Can't retry mkt.webapps.tasks.update_manifests ... - mkt.webapps.tasks.update_manifests

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

http://sentry.dmz.phx1.mozilla.com/marketplace-dev/group/3098/

First seen November 1.
'<@task: mkt.webapps.tasks.update_manifests>'

MaxRetriesExceededError: Can't retry mkt.webapps.tasks.update_manifests[a11d872f-e11c-4fe4-9480-39e168f74bc7] args:([394368L, 366239L],) kwargs:{'check_hash': True, 'retries': {394368L: 1, 366239L: 1}}

Stacktrace (most recent call last):

  File "celery/execute/trace.py", line 153, in trace_task
    R = retval = task(*args, **kwargs)
  File "nuggets/celeryutils.py", line 35, in wrapped
    return fun(*args, **kw)
  File "amo/decorators.py", line 160, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 152, in wrapper
    return f(*args, **kw)
  File "mkt/webapps/tasks.py", line 75, in update_manifests
    countdown=3600)
  File "celery/app/task/__init__.py", line 559, in retry
    self.name, options["task_id"], args, kwargs))

Comment 1

[Wil Clouser [:clouserw]]

It's hard for me to say who owns this one.  Basta or robhudson?  I'll give to ashort to investigate and fix or talk to one of those guys. Thanks!

Comment 2

[Allen Short [:ashort]]

After a lot of squinting at logs and sentry tracebacks, I don't see any apps being sent to the re-review queue by this code. I'm going to work on fixing that.

Comment 3

[Wil Clouser [:clouserw]]

sounds like robhudson is fixing this

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/92b5a6b

This logs retries, and also uses `eta` instead of `countdown` which seemingly has a timezone bug. `eta` will have more accurate retry durations.